From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCHSET v27.0 0/2] fstests: FIEXCHANGE is now an XFS ioctl
Date: Thu, 9 Nov 2023 20:48:54 -0800 [thread overview]
Message-ID: <20231110044854.GF1203404@frogsfrogsfrogs> (raw)
In-Reply-To: <20231109052106.GA29241@lst.de>
On Thu, Nov 09, 2023 at 06:21:06AM +0100, Christoph Hellwig wrote:
> On Wed, Nov 08, 2023 at 01:45:20PM -0800, Darrick J. Wong wrote:
> > This has been running on the djcloud for months with no problems. Enjoy!
> > Comments and questions are, as always, welcome.
>
> Isn't the branch all new?
>
> Anyway, this fixes skipping the tests when not supported, and runs them
> fine when supported:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>
Thanks!
> although I wonder a bit if keeping functionality not actually supported
> upstream in upstream xfstests is such a good idea. Keeping it in
> a development branch for the feature seems more flexible to me. I guess
> there is no point doing a forth and back for this one now, but maybe
> should be more careful in the future.
At the time Zorro proposed merging all the remaining online fsck tests I
didn't think review of the kernel patches was going to continue on for
years.
--D
prev parent reply other threads:[~2023-11-10 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 21:45 [PATCHSET v27.0 0/2] fstests: FIEXCHANGE is now an XFS ioctl Darrick J. Wong
2023-11-08 21:45 ` [PATCH 1/2] misc: privatize the FIEXCHANGE ioctl for now Darrick J. Wong
2023-11-16 15:14 ` Zorro Lang
2023-11-16 16:35 ` Darrick J. Wong
2023-11-08 21:45 ` [PATCH 2/2] misc: update xfs_io swapext usage Darrick J. Wong
2023-11-09 5:21 ` [PATCHSET v27.0 0/2] fstests: FIEXCHANGE is now an XFS ioctl Christoph Hellwig
2023-11-10 4:48 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110044854.GF1203404@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox