Re: [PATCH 06/13] iomap: move all remaining per-folio logic into xfs_writepage_map

Ritesh Harjani
2023-11-27T07:37:13Z

Christoph Hellwig <hch@lst.de> writes:

> Move the tracepoint and the iomap check from iomap_do_writepage into
> iomap_writepage_map. This keeps all logic in one places, and leaves
> iomap_do_writepage just as the wrapper for the callback conventions of
> write_cache_pages, which will go away when that is convertd to an
^^^ converted
> iterator.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/iomap/buffered-io.c | 34 +++++++++++-----------------------
> 1 file changed, 11 insertions(+), 23 deletions(-)

Straight forward refactoring. The change looks good to me. Please feel
free to add -

Reivewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>