Re: [PATCH 02/13] iomap: treat inline data in iomap_writepage_map as an I/O error

Christoph Hellwig
2023-11-29T05:39:51Z

On Tue, Nov 28, 2023 at 08:40:57PM -0800, Darrick J. Wong wrote:
> > I think they way it currently works for gfs2 is that writeback from the
> > page cache never goes back into the inline area.
> >
> > If we ever have a need to actually write back inline data we could
> > change this code to support it, but right now I just want to make the
> > assert more consistent.
>
> Question: Do we even /want/ writeback to be initiating transactions
> to log the inline data? I suppose for ext4/jbd2 that would be the least
> inefficient time to do that.

I think in general not, but it really depends on the file system
architecture. In other words: don't touch the current behavior unless
we have a good reason. I just want to make the error check a little
saner..