Re: [PATCH 02/13] iomap: treat inline data in iomap_writepage_map as an I/O error

Christoph Hellwig
2023-11-27T06:33:29Z

On Mon, Nov 27, 2023 at 10:31:31AM +0530, Ritesh Harjani wrote:
> The code change looks very obvious. But sorry that I have some queries
> which I would like to clarify -
>
> The dirty page we are trying to write can always belong to the dirty
> inode with inline data in it right?

Yes.

> So it is then the FS responsibility to un-inline the inode in the
> ->map_blocks call is it?

I think they way it currently works for gfs2 is that writeback from the
page cache never goes back into the inline area.

If we ever have a need to actually write back inline data we could
change this code to support it, but right now I just want to make the
assert more consistent.