From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, Carlos Maiolino <cmaiolino@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs_io: support passing the FORCE_REBUILD flag to online repair
Date: Mon, 27 Nov 2023 10:54:04 -0800 [thread overview]
Message-ID: <20231127185404.GE2766956@frogsfrogsfrogs> (raw)
In-Reply-To: <ZV7xc5ann7oeZNqY@infradead.org>
On Wed, Nov 22, 2023 at 10:30:11PM -0800, Christoph Hellwig wrote:
> On Wed, Nov 22, 2023 at 03:07:48PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Add CLI options to the scrubv and repair commands so that the user can
> > pass FORCE_REBUILD to force the kernel to rebuild metadata.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> I guess on it's own this looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Howerver I find the code structure here a bit odd and rather hard
> to follow. Why can't parse_args actually just do the parsing
> and return control, control2 and flags the caller and let do the
> work?
Sounds like a reasonable cleanup.
> While we're at it, shouldn't all the validation errors in parse_args
> set exitcode to 1?
Yes, they should. I'll add a new patch to fix that.
--D
>
next prev parent reply other threads:[~2023-11-27 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:07 [PATCHSET v27.0 0/4] xfsprogs: force rebuilding of metadata Darrick J. Wong
2023-11-22 23:07 ` [PATCH 1/4] xfs_io: support passing the FORCE_REBUILD flag to online repair Darrick J. Wong
2023-11-23 6:30 ` Christoph Hellwig
2023-11-27 18:54 ` Darrick J. Wong [this message]
2023-11-22 23:07 ` [PATCH 2/4] xfs_scrub: handle spurious wakeups in scan_fs_tree Darrick J. Wong
2023-11-23 6:31 ` Christoph Hellwig
2023-11-22 23:08 ` [PATCH 3/4] xfs_scrub: don't retry unsupported optimizations Darrick J. Wong
2023-11-23 6:32 ` Christoph Hellwig
2023-11-22 23:08 ` [PATCH 4/4] xfs_scrub: try to use XFS_SCRUB_IFLAG_FORCE_REBUILD Darrick J. Wong
2023-11-23 6:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127185404.GE2766956@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox