From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0537619BD; Tue, 28 Nov 2023 21:42:27 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 502BD227A87; Wed, 29 Nov 2023 06:42:25 +0100 (CET) Date: Wed, 29 Nov 2023 06:42:25 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Ritesh Harjani , Christian Brauner , Chandan Babu R , Zhang Yi , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 08/13] iomap: move the iomap_sector sector calculation out of iomap_add_to_ioend Message-ID: <20231129054225.GE1385@lst.de> References: <20231126124720.1249310-9-hch@lst.de> <87plzvr05y.fsf@doe.com> <20231127135402.GA23928@lst.de> <20231129045357.GN4167244@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129045357.GN4167244@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Nov 28, 2023 at 08:53:57PM -0800, Darrick J. Wong wrote: > Can you change @offset to @pos while you're changing the function > signature? Sure.