Re: [PATCH 2/6] xfs: check rt summary file geometry more thoroughly

Christoph Hellwig
2023-11-29T06:23:41Z

On Tue, Nov 28, 2023 at 10:21:55PM -0800, Darrick J. Wong wrote:
> On Tue, Nov 28, 2023 at 10:05:49PM -0800, Christoph Hellwig wrote:
> > On Tue, Nov 28, 2023 at 03:30:09PM -0800, Darrick J. Wong wrote:
> > > LOL so I just tried a 64k rt volume with a 1M rextsize and mkfs crashed.
> > > I guess I'll go sort out what's going on there...
> >
> > I think we should just reject rt device size < rtextsize configs in
> > the kernel and all tools.
>
> "But that could break old weirdass customer filesystems."
>
> The design of rtgroups prohibits that, so we're ok going forward.

Well, as you just said it hasn't mounted for a long time, and really
this is a corner case that just doesn't make any sense. I'd really
prefer to cleanly reject it, and if someone really complains with a good
reason we can revisit the decisions. But I strongly doubt it's ever
going to happen.