Re: [PATCH 1/5] xfs: create separate structures and code for u32 bitmaps

Christoph Hellwig
2023-11-28T05:43:59Z

On Mon, Nov 27, 2023 at 05:34:44PM -0800, Darrick J. Wong wrote:
> > Also why are the agb_bitmap* wrappers in bitmap.h? Following our
> > usual code organization I'd expect bitmap.[ch] to just be the
> > library code and have users outside of that. Maybe for later..
>
> Those wrappers are trivial except for the enhanced typechecking, so I
> didn't think it was a big deal to cram them into bitmap.h.

I find that kind of code structure a bit confusion to be honest.
If you prefer it I can live with it (at least fow now :)) of course.