Re: [PATCH 4/4] xfs: constrain dirty buffers while formatting a staged btree

Darrick J. Wong
2023-11-27T22:56:32Z

On Fri, Nov 24, 2023 at 09:53:38PM -0800, Christoph Hellwig wrote:
> > @@ -480,7 +500,7 @@ xfs_btree_bload_node(
> >
> > ASSERT(!xfs_btree_ptr_is_null(cur, child_ptr));
> >
> > - ret = xfs_btree_get_buf_block(cur, child_ptr, &child_block,
> > + ret = xfs_btree_read_buf_block(cur, child_ptr, 0, &child_block,
> > &child_bp);
>
> How is this (and making xfs_btree_read_buf_block outside of xfs_buf.c)
> related to the dirty limit?

Oh! Looking through my notes, I wanted the /new/ btree block buffers
have the same lru reference count the old ones did. I probably should
have exported xfs_btree_set_refs instead of reading whatever is on disk
into a buffer, only to blow away the contents anyway.

--D