Re: [PATCH 5/5] xfs: repair quotas

Christoph Hellwig
2023-11-30T05:33:41Z

> @@ -328,7 +328,6 @@ xchk_quota(
> if (error)
> break;
> }
> - xchk_ilock(sc, XFS_ILOCK_EXCL);
> if (error == -ECANCELED)
> error = 0;
> if (!xchk_fblock_process_error(sc, XFS_DATA_FORK,

What is the replacement for this lock? The call in xrep_quota_item?

I'm a little confused on how locking works - about all flags in
sc->ilock_flags are released, and here we used just lock the
exclusive ilock directly without tracking it.