Re: [PATCH 1/5] xfs: reintroduce reaping of file metadata blocks to xrep_reap_extents

Christoph Hellwig
2023-12-04T04:42:52Z

On Thu, Nov 30, 2023 at 01:48:24PM -0800, Darrick J. Wong wrote:
> > Can you expand a bit on why it was buggy, in what commit is was dropped
> > and what we're doing better this time around?
>
> Oh! We merged that one! Let me change the commit message:
>
> "Back in commit a55e07308831b ("xfs: only allow reaping of per-AG
> blocks in xrep_reap_extents"), we removed from the reaping code the
> ability to handle bmbt blocks. At the time, the reaping code only
> walked single blocks, didn't correctly detect crosslinked blocks, and
> the special casing made the function hard to understand. It was easier
> to remove unneeded functionality prior to fixing all the bugs.
>
> "Now that we've fixed the problems, we want again the ability to reap
> file metadata blocks. Reintroduce the per-file reaping functionality
> atop the current implementation. We require that sc->sa is
> uninitialized, so that we can use it to hold all the per-AG context for
> a given extent."

That looks much better, thanks!