Re: [PATCH 3/7] xfs: repair inode records

Christoph Hellwig
2023-12-06T05:16:33Z

On Tue, Dec 05, 2023 at 03:08:43PM -0800, Darrick J. Wong wrote:
> Hmm. I suppose a problem with "?" is that question-mark is a valid
> filename, which means that our zapped symlink could now suddenly point
> to a different file that a user created. "/lost+found" isn't different
> in that respect, but societal convention might at least provide for
> raised eyebrows. That said, mkfs.xfs doesn't create one for us like
> mke2fs does, so maybe a broken symlink to the orphanage is... well, now
> I'm bikeshedding my own creation.
>
> May I try to make a case for "🚽"? ;)

Haha.. I suspect not allowing to follow the link at all if is marked
sick is the best idea, i.e. the concept we've talked about for regular
files. Make that consistent for all file times, and then we need to
look into an expedited on-disk flag for that to make it persistent.

>
> /*
> * data fork blockcount can exceed physical storage if a
> * user reflinks the same block over and over again.
> */

Yup.

> if (!uid_valid(VFS_I(sc->ip)->i_uid)) {
> /* zap it */
> }

Perfect.