From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: chandanbabu@kernel.org, leo.lilong@huawei.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/8] xfs: pass the xfs_defer_pending object to iop_recover
Date: Mon, 4 Dec 2023 10:31:53 -0800 [thread overview]
Message-ID: <20231204183153.GX361584@frogsfrogsfrogs> (raw)
In-Reply-To: <20231204050426.GE26073@lst.de>
On Mon, Dec 04, 2023 at 06:04:26AM +0100, Christoph Hellwig wrote:
> Not sure if I missed it in my first round of review, or if this is new
> in this version, but this now generats a warning when asserts are
> disabled, given that the lip variable in xlog_recover_process_intents
> is only used in asserts. We'll need to remove it and just open code
> the dereference in the two asserts that use it.
Yeah, that's the last patch, and I forgot to address that warning
because the kbuild robot only sends email to my Outlook now. Clearly
I'm not doing CONFIG_XFS_DEBUG=n builds on my development box...
--D
next prev parent reply other threads:[~2023-12-04 18:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 19:00 [PATCHSET v2 0/8] xfs: log intent item recovery should reconstruct defer work state Darrick J. Wong
2023-12-03 19:00 ` [PATCH 1/8] xfs: don't leak recovered attri intent items Darrick J. Wong
2023-12-05 4:31 ` Christoph Hellwig
2023-12-05 5:19 ` Darrick J. Wong
2023-12-03 19:01 ` [PATCH 2/8] xfs: use xfs_defer_pending objects to recover " Darrick J. Wong
2023-12-04 5:03 ` Christoph Hellwig
2023-12-03 19:01 ` [PATCH 3/8] xfs: pass the xfs_defer_pending object to iop_recover Darrick J. Wong
2023-12-04 5:04 ` Christoph Hellwig
2023-12-04 18:31 ` Darrick J. Wong [this message]
2023-12-04 19:36 ` Christoph Hellwig
2023-12-03 19:01 ` [PATCH 4/8] xfs: transfer recovered intent item ownership in ->iop_recover Darrick J. Wong
2023-12-03 19:01 ` [PATCH 5/8] xfs: recreate work items when recovering intent items Darrick J. Wong
2023-12-04 5:05 ` Christoph Hellwig
2023-12-03 19:02 ` [PATCH 6/8] xfs: dump the recovered xattri log item if corruption happens Darrick J. Wong
2023-12-04 5:05 ` Christoph Hellwig
2023-12-03 19:02 ` [PATCH 7/8] xfs: use xfs_defer_finish_one to finish recovered work items Darrick J. Wong
2023-12-04 5:06 ` Christoph Hellwig
2023-12-03 19:02 ` [PATCH 8/8] xfs: move ->iop_recover to xfs_defer_op_type Darrick J. Wong
2023-12-04 19:05 ` [PATCH v2.1 " Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 2:22 [PATCHSET v3 0/8] xfs: log intent item recovery should reconstruct defer work state Darrick J. Wong
2023-12-07 2:23 ` [PATCH 3/8] xfs: pass the xfs_defer_pending object to iop_recover Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204183153.GX361584@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=hch@lst.de \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox