From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: make rextslog computation consistent with mkfs
Date: Mon, 4 Dec 2023 10:52:42 -0800 [thread overview]
Message-ID: <20231204185242.GA361584@frogsfrogsfrogs> (raw)
In-Reply-To: <20231204045526.GA26073@lst.de>
On Mon, Dec 04, 2023 at 05:55:26AM +0100, Christoph Hellwig wrote:
> > + */
> > +uint8_t
> > +xfs_compute_rextslog(
> > + xfs_rtbxlen_t rtextents)
> > +{
> > + return rtextents ? xfs_highbit32(rtextents) : 0;
>
> It might just be a personal pet peeve, but I find a good old if much
> more readable for this:
>
> if (!rtextents)
> return 0;
> return xfs_highbit32(rtextents);
>
> Otherwise looks good:
Same here. I'll adjust it in the next patch, since this one is the
copypastahappy hoist.
--D
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
>
next prev parent reply other threads:[~2023-12-04 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 19:00 [PATCHSET 0/3] xfs: fix realtime geometry integer overflows Darrick J. Wong
2023-12-03 19:05 ` [PATCH 1/3] xfs: make rextslog computation consistent with mkfs Darrick J. Wong
2023-12-04 4:55 ` Christoph Hellwig
2023-12-04 18:52 ` Darrick J. Wong [this message]
2023-12-03 19:05 ` [PATCH 2/3] xfs: fix 32-bit truncation in xfs_compute_rextslog Darrick J. Wong
2023-12-04 4:55 ` Christoph Hellwig
2023-12-03 19:05 ` [PATCH 3/3] xfs: don't allow overly small or large realtime volumes Darrick J. Wong
2023-12-03 19:09 ` Darrick J. Wong
2023-12-04 4:56 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 2:23 [PATCHSET v2 0/3] xfs: fix realtime geometry integer overflows Darrick J. Wong
2023-12-07 2:27 ` [PATCH 1/3] xfs: make rextslog computation consistent with mkfs Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204185242.GA361584@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox