From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463DEF0 for ; Mon, 4 Dec 2023 11:36:06 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B8F1E227A8E; Mon, 4 Dec 2023 20:36:03 +0100 (CET) Date: Mon, 4 Dec 2023 20:36:03 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , chandanbabu@kernel.org, leo.lilong@huawei.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/8] xfs: pass the xfs_defer_pending object to iop_recover Message-ID: <20231204193603.GA17599@lst.de> References: <170162989691.3037528.5056861908451814336.stgit@frogsfrogsfrogs> <170162989753.3037528.15154705573817500020.stgit@frogsfrogsfrogs> <20231204050426.GE26073@lst.de> <20231204183153.GX361584@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204183153.GX361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Dec 04, 2023 at 10:31:53AM -0800, Darrick J. Wong wrote: > On Mon, Dec 04, 2023 at 06:04:26AM +0100, Christoph Hellwig wrote: > > Not sure if I missed it in my first round of review, or if this is new > > in this version, but this now generats a warning when asserts are > > disabled, given that the lip variable in xlog_recover_process_intents > > is only used in asserts. We'll need to remove it and just open code > > the dereference in the two asserts that use it. > > Yeah, that's the last patch, and I forgot to address that warning > because the kbuild robot only sends email to my Outlook now. Clearly > I'm not doing CONFIG_XFS_DEBUG=n builds on my development box... You're getting email quickly from the bot then, for me these kinds of reports usually show up days later..