From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: document what LARP means
Date: Tue, 5 Dec 2023 06:56:42 +0100 [thread overview]
Message-ID: <20231205055642.GA30465@lst.de> (raw)
In-Reply-To: <20231205055028.GL361584@frogsfrogsfrogs>
On Mon, Dec 04, 2023 at 09:50:28PM -0800, Darrick J. Wong wrote:
> How about these last couple of sentences?
>
> /*
> * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob
> * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on
> * V5 filesystems. As a result, the intermediate progress of all setxattr and
> * removexattr operations are tracked via the log and can be restarted during
> * recovery. This is useful for testing xattr recovery prior to merging of the
> * parent pointer feature which requires it to maintain consistency, and may be
> * enabled for userspace xattrs in the future.
> */
Oooh. So all the logged attrs work is preparation for parent pointers?
That makes a whole lot of sense, but I've missed it so far. Yes, the
above comment is great.
With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-12-05 5:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 5:36 [PATCHSET 0/2] xfs: elide defer work ->create_done if no intent Darrick J. Wong
2023-12-05 5:36 ` [PATCH 1/2] xfs: document what LARP means Darrick J. Wong
2023-12-05 5:38 ` Christoph Hellwig
2023-12-05 5:50 ` Darrick J. Wong
2023-12-05 5:56 ` Christoph Hellwig [this message]
2023-12-05 6:09 ` Darrick J. Wong
2023-12-05 5:36 ` [PATCH 2/2] xfs: elide ->create_done calls for unlogged deferred work Darrick J. Wong
2023-12-05 5:39 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 2:23 [PATCHSET v2 0/2] xfs: elide defer work ->create_done if no intent Darrick J. Wong
2023-12-07 2:28 ` [PATCH 1/2] xfs: document what LARP means Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205055642.GA30465@lst.de \
--to=hch@lst.de \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox