From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 624B211F for ; Mon, 4 Dec 2023 21:56:45 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 6C30F68B05; Tue, 5 Dec 2023 06:56:42 +0100 (CET) Date: Tue, 5 Dec 2023 06:56:42 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , chandanbabu@kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] xfs: document what LARP means Message-ID: <20231205055642.GA30465@lst.de> References: <170175456196.3910588.9712198406317844529.stgit@frogsfrogsfrogs> <170175456779.3910588.8343836136719400292.stgit@frogsfrogsfrogs> <20231205053842.GA30199@lst.de> <20231205055028.GL361584@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205055028.GL361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Dec 04, 2023 at 09:50:28PM -0800, Darrick J. Wong wrote: > How about these last couple of sentences? > > /* > * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob > * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on > * V5 filesystems. As a result, the intermediate progress of all setxattr and > * removexattr operations are tracked via the log and can be restarted during > * recovery. This is useful for testing xattr recovery prior to merging of the > * parent pointer feature which requires it to maintain consistency, and may be > * enabled for userspace xattrs in the future. > */ Oooh. So all the logged attrs work is preparation for parent pointers? That makes a whole lot of sense, but I've missed it so far. Yes, the above comment is great. With that: Reviewed-by: Christoph Hellwig