From: Long Li <leo.lilong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <djwong@kernel.org>, <chandanbabu@kernel.org>,
<linux-xfs@vger.kernel.org>, <yi.zhang@huawei.com>,
<houtao1@huawei.com>, <yangerkun@huawei.com>
Subject: Re: [PATCH 2/2] xfs: fix perag leak when growfs fails
Date: Wed, 6 Dec 2023 20:48:07 +0800 [thread overview]
Message-ID: <20231206124807.GB3413285@ceph-admin> (raw)
In-Reply-To: <ZW6pMHNK/tUxsbuM@infradead.org>
On Mon, Dec 04, 2023 at 08:38:08PM -0800, Christoph Hellwig wrote:
> > +void
> > +xfs_destroy_perag(
> > + xfs_mount_t *mp,
> > + xfs_agnumber_t agstart,
> > + xfs_agnumber_t agend)
>
> Not sure xfs_destroy_perag is the right name, as it frees a range of
> AGs, how about xfs_free_unuses_perag_range?
Yes, it looks better.
But I'm not sure if it's better to use xfs_free_unused_perag_range?
>
> Also a comment explaining that this must never be used for AGs that
> have been visible (that is included in mp->m_sb.sb_agcount) would
> probably be useful.
>
This will be changed in the next version.
Thanks,
Long Li
next prev parent reply other threads:[~2023-12-06 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 4:39 [PATCH 1/2] xfs: add lock protection when remove perag from radix tree Long Li
2023-12-04 4:39 ` [PATCH 2/2] xfs: fix perag leak when growfs fails Long Li
2023-12-05 4:38 ` Christoph Hellwig
2023-12-06 12:48 ` Long Li [this message]
2023-12-05 4:35 ` [PATCH 1/2] xfs: add lock protection when remove perag from radix tree Christoph Hellwig
2023-12-05 21:28 ` Dave Chinner
2023-12-06 12:32 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206124807.GB3413285@ceph-admin \
--to=leo.lilong@huawei.com \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox