From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <dchinner@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/7] xfs: repair free space btrees
Date: Mon, 11 Dec 2023 11:15:30 -0800 [thread overview]
Message-ID: <20231211191530.GS361584@frogsfrogsfrogs> (raw)
In-Reply-To: <ZXFYa7v7m1vkuwnY@infradead.org>
On Wed, Dec 06, 2023 at 09:30:19PM -0800, Christoph Hellwig wrote:
> On Wed, Dec 06, 2023 at 06:41:10PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Rebuild the free space btrees from the gaps in the rmap btree.
> > Refer to the linked documentation for more details.
> >
> > Link: https://docs.kernel.org/filesystems/xfs-online-fsck-design.html#case-study-rebuilding-the-free-space-indices
>
> Nit: linking the file in the kernel tree that this is generated from it
> and requires internet access would seem more useful.
Er... assuming you are asking for a link to the file in the kernel tree
from which the HTML is generated so as /not/ to require internet access,
I'll add:
"Link: Documentation/filesystems/xfs-online-fsck-design.rst"
That said, I couldn't find any particular precedent in Documentation/
for having Link: tags in patches that point to paths underneath
Documentation/ so I guess I'll just make s*** up like always, then wait
and see how many auto-nag emails I get about how I've broken some random
rule somewhere. :P
--D
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
next prev parent reply other threads:[~2023-12-11 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 2:38 [PATCHSET v28.1 0/7] xfs: online repair of AG btrees Darrick J. Wong
2023-12-07 2:40 ` [PATCH 1/7] xfs: create separate structures and code for u32 bitmaps Darrick J. Wong
2023-12-07 2:40 ` [PATCH 2/7] xfs: move the per-AG datatype bitmaps to separate files Darrick J. Wong
2023-12-07 5:27 ` Christoph Hellwig
2023-12-07 2:40 ` [PATCH 3/7] xfs: roll the scrub transaction after completing a repair Darrick J. Wong
2023-12-07 2:40 ` [PATCH 4/7] xfs: remove trivial bnobt/inobt scrub helpers Darrick J. Wong
2023-12-07 5:28 ` Christoph Hellwig
2023-12-07 2:41 ` [PATCH 5/7] xfs: repair free space btrees Darrick J. Wong
2023-12-07 5:30 ` Christoph Hellwig
2023-12-11 19:15 ` Darrick J. Wong [this message]
2023-12-11 19:32 ` Christoph Hellwig
2023-12-07 2:41 ` [PATCH 6/7] xfs: repair inode btrees Darrick J. Wong
2023-12-07 5:30 ` Christoph Hellwig
2023-12-07 2:41 ` [PATCH 7/7] xfs: repair refcount btrees Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211191530.GS361584@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox