From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Chandan Babu R <chandan.babu@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 01/19] xfs: consider minlen sized extents in xfs_rtallocate_extent_block
Date: Thu, 14 Dec 2023 13:02:43 -0800 [thread overview]
Message-ID: <20231214210243.GA361584@frogsfrogsfrogs> (raw)
In-Reply-To: <20231214063438.290538-2-hch@lst.de>
On Thu, Dec 14, 2023 at 07:34:20AM +0100, Christoph Hellwig wrote:
> minlen is the lower bound on the extent length that the caller can
> accept, and maxlen is at this point the maximal available length.
> This means a minlen extent is perfectly fine to use, so do it. This
> matches the equivalent logic in xfs_rtallocate_extent_exact that also
> accepts a minlen sized extent.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_rtalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 8feb58c6241ce4..fe98a96a26484f 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -309,7 +309,7 @@ xfs_rtallocate_extent_block(
> /*
> * Searched the whole thing & didn't find a maxlen free extent.
> */
> - if (minlen < maxlen && besti != -1) {
> + if (minlen <= maxlen && besti != -1) {
> xfs_rtxlen_t p; /* amount to trim length by */
>
> /*
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2023-12-14 21:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 6:34 RT allocator tidy ups Christoph Hellwig
2023-12-14 6:34 ` [PATCH 01/19] xfs: consider minlen sized extents in xfs_rtallocate_extent_block Christoph Hellwig
2023-12-14 21:02 ` Darrick J. Wong [this message]
2023-12-14 6:34 ` [PATCH 02/19] xfs: turn the xfs_trans_mod_dquot_byino stub into an inline function Christoph Hellwig
2023-12-14 20:44 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 03/19] xfs: remove the xfs_alloc_arg argument to xfs_bmap_btalloc_accounting Christoph Hellwig
2023-12-14 20:46 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 04/19] xfs: also use xfs_bmap_btalloc_accounting for RT allocations Christoph Hellwig
2023-12-14 20:46 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 05/19] xfs: move xfs_bmap_rtalloc to xfs_rtalloc.c Christoph Hellwig
2023-12-14 20:48 ` Darrick J. Wong
2023-12-15 4:09 ` Christoph Hellwig
2023-12-15 6:35 ` Christoph Hellwig
2023-12-14 6:34 ` [PATCH 06/19] xfs: return -ENOSPC from xfs_rtallocate_* Christoph Hellwig
2023-12-14 20:50 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 07/19] xfs: reflow the tail end of xfs_bmap_rtalloc Christoph Hellwig
2023-12-14 20:51 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 08/19] xfs: indicate if xfs_bmap_adjacent changed ap->blkno Christoph Hellwig
2023-12-14 20:52 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 09/19] xfs: cleanup picking the start extent hint in xfs_bmap_rtalloc Christoph Hellwig
2023-12-14 20:59 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 10/19] xfs: move xfs_rtget_summary to xfs_rtbitmap.c Christoph Hellwig
2023-12-14 21:00 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 11/19] xfs: split xfs_rtmodify_summary_int Christoph Hellwig
2023-12-14 21:02 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 12/19] xfs: tidy up xfs_rtallocate_extent_block Christoph Hellwig
2023-12-14 21:16 ` Darrick J. Wong
2023-12-15 4:10 ` Christoph Hellwig
2023-12-14 6:34 ` [PATCH 13/19] xfs: tidy up xfs_rtallocate_extent_exact Christoph Hellwig
2023-12-14 21:17 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 14/19] xfs: factor out a xfs_rtalloc_sumlevel helper Christoph Hellwig
2023-12-14 21:05 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 15/19] xfs: remove rt-wrappers from xfs_format.h Christoph Hellwig
2023-12-14 21:18 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 16/19] xfs: remove XFS_RTMIN/XFS_RTMAX Christoph Hellwig
2023-12-14 21:21 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 17/19] xfs: reorder the minlen and prod calculations in xfs_bmap_rtalloc Christoph Hellwig
2023-12-14 21:24 ` Darrick J. Wong
2023-12-14 6:34 ` [PATCH 18/19] xfs: simplify and optimize the RT allocation fallback cascade Christoph Hellwig
2023-12-14 21:32 ` Darrick J. Wong
2023-12-15 4:12 ` Christoph Hellwig
2023-12-14 6:34 ` [PATCH 19/19] xfs: fold xfs_rtallocate_extent into xfs_bmap_rtalloc Christoph Hellwig
2023-12-14 21:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214210243.GA361584@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox