Re: [PATCH 2/9] xfs: defrag: initialization and cleanup

[kernel test robot <lkp@intel.com>]

Hi Wengang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.7-rc5 next-20231215]
[cannot apply to xfs-linux/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wengang-Wang/xfs-defrag-introduce-strucutures-and-numbers/20231215-011549
base:   linus/master
patch link:    https://lore.kernel.org/r/20231214170530.8664-3-wen.gang.wang%40oracle.com
patch subject: [PATCH 2/9] xfs: defrag: initialization and cleanup
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20231215/202312152127.vB6dhbqO-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312152127.vB6dhbqO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312152127.vB6dhbqO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/xfs/xfs_defrag.c:58:6: warning: no previous prototype for 'xfs_initialize_defrag' [-Wmissing-prototypes]
      58 | void xfs_initialize_defrag(struct xfs_mount *mp)
         |      ^~~~~~~~~~~~~~~~~~~~~
>> fs/xfs/xfs_defrag.c:67:6: warning: no previous prototype for 'xfs_stop_wait_defrags' [-Wmissing-prototypes]
      67 | void xfs_stop_wait_defrags(struct xfs_mount *mp)
         |      ^~~~~~~~~~~~~~~~~~~~~
   fs/xfs/xfs_defrag.c:80:5: warning: no previous prototype for 'xfs_file_defrag' [-Wmissing-prototypes]
      80 | int xfs_file_defrag(struct file *filp, struct xfs_defrag *defrag)
         |     ^~~~~~~~~~~~~~~


vim +/xfs_initialize_defrag +58 fs/xfs/xfs_defrag.c

    56	
    57	/* initialization called for new mount */
  > 58	void xfs_initialize_defrag(struct xfs_mount *mp)
    59	{
    60		sema_init(&mp->m_defrag_lock, 1);
    61		mp->m_nr_defrag = 0;
    62		mp->m_defrag_task = NULL;
    63		INIT_LIST_HEAD(&mp->m_defrag_list);
    64	}
    65	
    66	/* stop all the defragmentations on this mount and wait until they really stopped */
  > 67	void xfs_stop_wait_defrags(struct xfs_mount *mp)
    68	{
    69		down(&mp->m_defrag_lock);
    70		if (list_empty(&mp->m_defrag_list)) {
    71			up(&mp->m_defrag_lock);
    72			return;
    73		}
    74		ASSERT(mp->m_defrag_task);
    75		up(&mp->m_defrag_lock);
    76		kthread_stop(mp->m_defrag_task);
    77		mp->m_defrag_task = NULL;
    78	}
    79	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki