Re: [PATCH 3/8] xfs: move the xfs_attr_sf_lookup tracepoint

["Darrick J. Wong" <djwong@kernel.org>]

On Sun, Dec 17, 2023 at 06:03:45PM +0100, Christoph Hellwig wrote:
> trace_xfs_attr_sf_lookup is currently only called by
> xfs_attr_shortform_lookup, which despit it's name is a simple helper for
> xfs_attr_shortform_addname, which has it's own tracing.  Move the
> callsite to xfs_attr_shortform_getvalue, which is the closest thing to
> a high level lookup we have for the Linux xattr API.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/xfs/libxfs/xfs_attr_leaf.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index 2e3334ac32287a..37474af8ee4633 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -876,8 +876,6 @@ xfs_attr_shortform_lookup(
>  	struct xfs_attr_sf_entry	*sfe;
>  	int				i;
>  
> -	trace_xfs_attr_sf_lookup(args);
> -
>  	ASSERT(ifp->if_format == XFS_DINODE_FMT_LOCAL);
>  	sfe = &sf->list[0];
>  	for (i = 0; i < sf->hdr.count;
> @@ -905,6 +903,9 @@ xfs_attr_shortform_getvalue(
>  	int				i;
>  
>  	ASSERT(args->dp->i_af.if_format == XFS_DINODE_FMT_LOCAL);
> +
> +	trace_xfs_attr_sf_lookup(args);

Shouldn't this get renamed to trace_xfs_attr_shortform_getvalue to match
the function?  Especially since xfs_attr_shortform_lookup disappears
later, AFAICT.

--D

> +
>  	sfe = &sf->list[0];
>  	for (i = 0; i < sf->hdr.count;
>  				sfe = xfs_attr_sf_nextentry(sfe), i++) {
> -- 
> 2.39.2
> 
>