From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/8] xfs: remove xfs_attr_shortform_lookup
Date: Wed, 20 Dec 2023 04:55:20 +0100 [thread overview]
Message-ID: <20231220035520.GA30958@lst.de> (raw)
In-Reply-To: <20231219174505.GM361584@frogsfrogsfrogs>
On Tue, Dec 19, 2023 at 09:45:05AM -0800, Darrick J. Wong wrote:
> Eh, there's lots of, uh, cleanup opportunities in the xattr code. ;)
>
> The changes below look reasonable, but I wonder -- the leaf and node add
> functions do a similar thing; can they go too?
>
> I'm assuming those can't go away because they actually set @args->index
> and @args->rmt* and we might've blown that away after the initial lookup
> in xfs_attr_set? But maybe they can? Insofar as figuring all that out
> is probably an entire campaign on its own.
Yeah, this looks pretty scary to touch for a cleanup series that's
already gone kinda out of bounds..
>
> > So.. I'm tempted to just turn these checks into asserts with something
> > like the below on top of this patch, I'll just need to see if it survives
> > testing:
>
> I'll await your return then. :)
It has been surviving testing just fine over night.
next prev parent reply other threads:[~2023-12-20 3:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 12:08 attr cleanups v2 Christoph Hellwig
2023-12-19 12:08 ` [PATCH 1/8] xfs: make if_data a void pointer Christoph Hellwig
2023-12-19 12:08 ` [PATCH 2/8] xfs: return if_data from xfs_idata_realloc Christoph Hellwig
2023-12-19 12:08 ` [PATCH 3/8] xfs: move the xfs_attr_sf_lookup tracepoint Christoph Hellwig
2023-12-19 12:08 ` [PATCH 4/8] xfs: simplify xfs_attr_sf_findname Christoph Hellwig
2023-12-19 12:08 ` [PATCH 5/8] xfs: remove xfs_attr_shortform_lookup Christoph Hellwig
2023-12-19 14:46 ` Christoph Hellwig
2023-12-19 17:45 ` Darrick J. Wong
2023-12-20 3:55 ` Christoph Hellwig [this message]
2023-12-19 12:08 ` [PATCH 6/8] xfs: use xfs_attr_sf_findname in xfs_attr_shortform_getvalue Christoph Hellwig
2023-12-19 12:08 ` [PATCH 7/8] xfs: remove struct xfs_attr_shortform Christoph Hellwig
2023-12-19 17:35 ` Darrick J. Wong
2023-12-19 12:08 ` [PATCH 8/8] xfs: remove xfs_attr_sf_hdr_t Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-12-17 17:03 attr cleanups Christoph Hellwig
2023-12-17 17:03 ` [PATCH 5/8] xfs: remove xfs_attr_shortform_lookup Christoph Hellwig
2023-12-18 22:37 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220035520.GA30958@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).