From: Christoph Hellwig <hch@lst.de>
To: Chandan Babu R <chandan.babu@oracle.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>, linux-xfs@vger.kernel.org
Subject: attr cleanups v3
Date: Wed, 20 Dec 2023 07:34:54 +0100 [thread overview]
Message-ID: <20231220063503.1005804-1-hch@lst.de> (raw)
Hi all,
this series started by trying to remove xfs_attr_shortform as sparse
complains about it due using a variable sized array in struct using in a
variable sized array. I ended up cleaning a lot more code around it
once I started looking into it, including some basic cleanups for the
inode fork inline data memory management (I'll have another series for
more work there at a later time).
Note that the dir2 equivalent for the structure has already been removed
long time ago.
Changes since v2:
- fix use of an uninitialized error variable for impossible to hit code
paths
- add a patch to turn the above checks into asserts
Changes since v1:
- fix commit message typos
- better document the shortform attr layout, stealing text from the
dir2_sf definition.
Diffstat:
libxfs/xfs_attr.c | 33 ++----
libxfs/xfs_attr_leaf.c | 215 ++++++++++++++------------------------------
libxfs/xfs_attr_leaf.h | 7 -
libxfs/xfs_attr_sf.h | 24 +++-
libxfs/xfs_bmap.c | 4
libxfs/xfs_da_format.h | 33 +++---
libxfs/xfs_dir2.c | 2
libxfs/xfs_dir2_block.c | 6 -
libxfs/xfs_dir2_sf.c | 78 ++++++---------
libxfs/xfs_iext_tree.c | 36 +++----
libxfs/xfs_inode_fork.c | 70 ++++++--------
libxfs/xfs_inode_fork.h | 10 --
libxfs/xfs_ondisk.h | 14 +-
libxfs/xfs_symlink_remote.c | 4
scrub/attr.c | 17 +--
scrub/inode_repair.c | 4
scrub/readdir.c | 6 -
scrub/symlink.c | 2
xfs_attr_list.c | 13 +-
xfs_dir2_readdir.c | 6 -
xfs_inode.c | 6 -
xfs_inode_item.c | 10 --
xfs_symlink.c | 4
23 files changed, 245 insertions(+), 359 deletions(-)
next reply other threads:[~2023-12-20 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 6:34 Christoph Hellwig [this message]
2023-12-20 6:34 ` [PATCH 1/9] xfs: make if_data a void pointer Christoph Hellwig
2023-12-20 6:34 ` [PATCH 2/9] xfs: return if_data from xfs_idata_realloc Christoph Hellwig
2023-12-20 6:34 ` [PATCH 3/9] xfs: move the xfs_attr_sf_lookup tracepoint Christoph Hellwig
2023-12-20 6:34 ` [PATCH 4/9] xfs: simplify xfs_attr_sf_findname Christoph Hellwig
2023-12-20 6:34 ` [PATCH 5/9] xfs: remove xfs_attr_shortform_lookup Christoph Hellwig
2023-12-20 6:35 ` [PATCH 6/9] xfs: use xfs_attr_sf_findname in xfs_attr_shortform_getvalue Christoph Hellwig
2023-12-20 6:35 ` [PATCH 7/9] xfs: remove struct xfs_attr_shortform Christoph Hellwig
2023-12-20 7:09 ` Darrick J. Wong
2023-12-20 6:35 ` [PATCH 8/9] xfs: remove xfs_attr_sf_hdr_t Christoph Hellwig
2023-12-20 6:35 ` [PATCH 9/9] xfs: turn the XFS_DA_OP_REPLACE checks in xfs_attr_shortform_addname into asserts Christoph Hellwig
2023-12-20 7:09 ` Darrick J. Wong
2023-12-20 21:02 ` attr cleanups v3 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220063503.1005804-1-hch@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).