public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix backwards logic in xfs_bmap_alloc_account
Date: Mon, 8 Jan 2024 21:08:48 -0800	[thread overview]
Message-ID: <20240109050848.GD723010@frogsfrogsfrogs> (raw)
In-Reply-To: <ZZzNQ4/QkDxa0JIW@infradead.org>

On Mon, Jan 08, 2024 at 08:36:19PM -0800, Christoph Hellwig wrote:
> On Mon, Jan 08, 2024 at 06:17:34PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > We're only allocating from the realtime device if the inode is marked
> > for realtime and we're /not/ allocating into the attr fork.
> 
> Hmm, interesting how this survived all my rtalloc tests.  How did you
> find this?

I actually found it while reabasing the rt reflink patchset atop
for-next, because you unified the bmap allocator accounting functions
instead of copy-pasting them like I did.  Then I tried generic/476 and
it blew up the first time it encountered a reflink file.

> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!  Chandan, can we get this merged?

--D

  reply	other threads:[~2024-01-09  5:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  2:17 [PATCH] xfs: fix backwards logic in xfs_bmap_alloc_account Darrick J. Wong
2024-01-09  4:36 ` Christoph Hellwig
2024-01-09  5:08   ` Darrick J. Wong [this message]
2024-01-09 10:23     ` Chandan Babu R
2024-01-10 10:11 ` Chandan Babu R
2024-01-10 17:47   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109050848.GD723010@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=chandanrlinux@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox