* [PATCH] xfs/262: call _supports_xfs_scrub
@ 2024-01-10 17:45 Christoph Hellwig
2024-01-10 17:49 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2024-01-10 17:45 UTC (permalink / raw)
To: zlang; +Cc: djwong, fstests, linux-xfs
Call _supports_xfs_scrub so that the test is _notrun on kernels
without online scrub support.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/262 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/xfs/262 b/tests/xfs/262
index b28a6c88b..6df3c79f3 100755
--- a/tests/xfs/262
+++ b/tests/xfs/262
@@ -29,6 +29,9 @@ _require_xfs_io_error_injection "force_repair"
echo "Format and populate"
_scratch_mkfs > "$seqres.full" 2>&1
_scratch_mount
+
+_supports_xfs_scrub $SCRATCH_MNT $SCRATCH_DEV || _notrun "Scrub not supported"
+
cp $XFS_SCRUB_PROG $SCRATCH_MNT/xfs_scrub
$LDD_PROG $XFS_SCRUB_PROG | sed -e '/\//!d;/linux-gate/d;/=>/ {s/.*=>[[:blank:]]*\([^[:blank:]]*\).*/\1/};s/[[:blank:]]*\([^[:blank:]]*\) (.*)/\1/' | while read lib; do
cp $lib $SCRATCH_MNT/
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs/262: call _supports_xfs_scrub
2024-01-10 17:45 [PATCH] xfs/262: call _supports_xfs_scrub Christoph Hellwig
@ 2024-01-10 17:49 ` Darrick J. Wong
2024-01-10 17:52 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2024-01-10 17:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: zlang, fstests, linux-xfs
On Wed, Jan 10, 2024 at 06:45:44PM +0100, Christoph Hellwig wrote:
> Call _supports_xfs_scrub so that the test is _notrun on kernels
> without online scrub support.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> tests/xfs/262 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/xfs/262 b/tests/xfs/262
> index b28a6c88b..6df3c79f3 100755
> --- a/tests/xfs/262
> +++ b/tests/xfs/262
> @@ -29,6 +29,9 @@ _require_xfs_io_error_injection "force_repair"
> echo "Format and populate"
> _scratch_mkfs > "$seqres.full" 2>&1
> _scratch_mount
> +
> +_supports_xfs_scrub $SCRATCH_MNT $SCRATCH_DEV || _notrun "Scrub not supported"
Can you refactor this into a common _scratch_require_xfs_scrub helper
for xfs/556 and xfs/716?
The patch itself looks sound.
--D
> +
> cp $XFS_SCRUB_PROG $SCRATCH_MNT/xfs_scrub
> $LDD_PROG $XFS_SCRUB_PROG | sed -e '/\//!d;/linux-gate/d;/=>/ {s/.*=>[[:blank:]]*\([^[:blank:]]*\).*/\1/};s/[[:blank:]]*\([^[:blank:]]*\) (.*)/\1/' | while read lib; do
> cp $lib $SCRATCH_MNT/
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs/262: call _supports_xfs_scrub
2024-01-10 17:49 ` Darrick J. Wong
@ 2024-01-10 17:52 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-01-10 17:52 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, zlang, fstests, linux-xfs
On Wed, Jan 10, 2024 at 09:49:33AM -0800, Darrick J. Wong wrote:
> > +_supports_xfs_scrub $SCRATCH_MNT $SCRATCH_DEV || _notrun "Scrub not supported"
>
> Can you refactor this into a common _scratch_require_xfs_scrub helper
> for xfs/556 and xfs/716?
Sure, I'll look into that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-10 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 17:45 [PATCH] xfs/262: call _supports_xfs_scrub Christoph Hellwig
2024-01-10 17:49 ` Darrick J. Wong
2024-01-10 17:52 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox