From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/4] xfs: add a _scratch_require_xfs_scrub helper
Date: Fri, 12 Jan 2024 08:42:10 -0800 [thread overview]
Message-ID: <20240112164210.GR722975@frogsfrogsfrogs> (raw)
In-Reply-To: <20240112141410.GB5876@lst.de>
On Fri, Jan 12, 2024 at 03:14:10PM +0100, Christoph Hellwig wrote:
> On Fri, Jan 12, 2024 at 09:32:05PM +0800, Zorro Lang wrote:
> > Usually we name a require helper as _require_xxxxxxxx, you can find that
> > by running `grep -rsn scratch_require common/` and `grep -rsn require_scratch common/`.
> >
> > So better to change this name to _require_scratch_xfs_scrub. That's a simple
> > change, I can help to change that when I merge this patchset.
>
> Fine with me. I just took the name that Darrick suggested.
Either name is fine with me, so go with what the maintainer recommends.
Sorry for the churn :)
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
>
next prev parent reply other threads:[~2024-01-12 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 5:08 _supports_xfs_scrub cleanups v2 Christoph Hellwig
2024-01-12 5:08 ` [PATCH 1/4] xfs: check that the mountpoint is actually mounted in _supports_xfs_scrub Christoph Hellwig
2024-01-12 13:20 ` Zorro Lang
2024-01-12 16:41 ` Darrick J. Wong
2024-01-12 5:08 ` [PATCH 2/4] xfs: add a _scratch_require_xfs_scrub helper Christoph Hellwig
2024-01-12 13:32 ` Zorro Lang
2024-01-12 14:14 ` Christoph Hellwig
2024-01-12 16:42 ` Darrick J. Wong [this message]
2024-01-12 5:08 ` [PATCH 3/4] xfs/262: call _scratch_require_xfs_scrub Christoph Hellwig
2024-01-12 16:43 ` Darrick J. Wong
2024-01-12 5:08 ` [PATCH 4/4] xfs/506: " Christoph Hellwig
2024-01-12 16:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112164210.GR722975@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox