Re: [PATCH 1/4] libxfs: remove the unused fs_topology_t typedef

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Jan 12, 2024 at 05:47:40AM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  libxfs/topology.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libxfs/topology.h b/libxfs/topology.h
> index 1af5b0549..3a309a4da 100644
> --- a/libxfs/topology.h
> +++ b/libxfs/topology.h
> @@ -10,13 +10,13 @@
>  /*
>   * Device topology information.
>   */
> -typedef struct fs_topology {
> +struct fs_topology {
>  	int	dsunit;		/* stripe unit - data subvolume */
>  	int	dswidth;	/* stripe width - data subvolume */
>  	int	rtswidth;	/* stripe width - rt subvolume */
>  	int	lsectorsize;	/* logical sector size &*/

Dumb nit: the ampersand in the comment can go away too ^

Don't much care either way though.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  	int	psectorsize;	/* physical sector size */
> -} fs_topology_t;
> +};
>  
>  void
>  get_topology(
> -- 
> 2.39.2
> 
>