Re: [PATCH 07/20] shmem: document how to "persist" data when using shmem_*file_setup

Christoph Hellwig
2024-01-30T08:04:10Z

On Tue, Jan 30, 2024 at 06:06:12AM +0000, Matthew Wilcox wrote:
> On Mon, Jan 29, 2024 at 03:34:49PM +0100, Christoph Hellwig wrote:
> > Add a blurb that simply dirtying the folio will persist data for in-kernel
> > shmem files. This is what most of the callers already do.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> I noticed today that drivers/gpu/drm/i915/gem/i915_gem_shmem.c is
> going to a lot of effort to call write_begin and write_end. I'll
> take that out as part of the shmem conversion to buffered_write_ops.

I was planning to look into that, but I'll happily leave it to.
It also calls into ->writepage in a somewhat gross way.