public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Catherine Hoang <catherine.hoang@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 6.6 CANDIDATE v2 06/21] xfs: fix units conversion error in xfs_bmap_del_extent_delay
Date: Mon,  5 Feb 2024 14:19:56 -0800	[thread overview]
Message-ID: <20240205222011.95476-7-catherine.hoang@oracle.com> (raw)
In-Reply-To: <20240205222011.95476-1-catherine.hoang@oracle.com>

From: "Darrick J. Wong" <djwong@kernel.org>

commit ddd98076d5c075c8a6c49d9e6e8ee12844137f23 upstream.

The unit conversions in this function do not make sense.  First we
convert a block count to bytes, then divide that bytes value by
rextsize, which is in blocks, to get an rt extent count.  You can't
divide bytes by blocks to get a (possibly multiblock) extent value.

Fortunately nobody uses delalloc on the rt volume so this hasn't
mattered.

Fixes: fa5c836ca8eb5 ("xfs: refactor xfs_bunmapi_cow")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 26bfa34b4bbf..617cc7e78e38 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -4827,7 +4827,7 @@ xfs_bmap_del_extent_delay(
 	ASSERT(got_endoff >= del_endoff);
 
 	if (isrt) {
-		uint64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount);
+		uint64_t	rtexts = del->br_blockcount;
 
 		do_div(rtexts, mp->m_sb.sb_rextsize);
 		xfs_mod_frextents(mp, rtexts);
-- 
2.39.3


  parent reply	other threads:[~2024-02-05 22:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 22:19 [PATCH 6.6 CANDIDATE v2 00/21] xfs backports for 6.6.y (from v6.7) Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 01/21] MAINTAINERS: add Catherine as xfs maintainer for 6.6.y Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 02/21] xfs: bump max fsgeom struct version Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 03/21] xfs: hoist freeing of rt data fork extent mappings Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 04/21] xfs: prevent rt growfs when quota is enabled Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 05/21] xfs: rt stubs should return negative errnos when rt disabled Catherine Hoang
2024-02-05 22:19 ` Catherine Hoang [this message]
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 07/21] xfs: make sure maxlen is still congruent with prod when rounding down Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 08/21] xfs: introduce protection for drop nlink Catherine Hoang
2024-02-05 22:19 ` [PATCH 6.6 CANDIDATE v2 09/21] xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 10/21] xfs: allow read IO and FICLONE to run concurrently Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 11/21] xfs: factor out xfs_defer_pending_abort Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 12/21] xfs: abort intent items when recovery intents fail Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 13/21] xfs: only remap the written blocks in xfs_reflink_end_cow_extent Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 14/21] xfs: up(ic_sema) if flushing data device fails Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 15/21] xfs: fix internal error from AGFL exhaustion Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 16/21] xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 17/21] xfs: inode recovery does not validate the recovered inode Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 18/21] xfs: clean up dqblk extraction Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 19/21] xfs: dquot recovery does not validate the recovered dquot Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 20/21] xfs: clean up FS_XFLAG_REALTIME handling in xfs_ioctl_setattr_xflags Catherine Hoang
2024-02-05 22:20 ` [PATCH 6.6 CANDIDATE v2 21/21] xfs: respect the stable writes flag on the RT device Catherine Hoang
2024-02-06  5:23 ` [PATCH 6.6 CANDIDATE v2 00/21] xfs backports for 6.6.y (from v6.7) Chandan Babu R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205222011.95476-7-catherine.hoang@oracle.com \
    --to=catherine.hoang@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox