linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] debian: Increase build verbosity, add terse support
       [not found] <Zco4xFPmGJQshw7n@ariel>
@ 2024-02-12 23:07 ` Bastian Germann
  2024-02-12 23:29   ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Bastian Germann @ 2024-02-12 23:07 UTC (permalink / raw)
  To: linux-xfs; +Cc: Bastian Germann, Emanuele Rocca

Section 4.9 of the Debian Policy reads:

"The package build should be as verbose as reasonably possible,
except where the terse tag is included in DEB_BUILD_OPTIONS".

Implement such behavior for xfsprogs by passing V=1 to make by default.

Link: https://www.debian.org/doc/debian-policy/ch-source.html#main-building-script-debian-rules
Link: https://bugs.debian.org/1063774
Reported-by: Emanuele Rocca <ema@debian.org>
Signed-off-by: Bastian Germann <bage@debian.org>
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index 57baad62..7e4b83e2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,6 +7,10 @@ ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
     PMAKEFLAGS += -j$(NUMJOBS)
 endif
 
+ifeq (,$(filter terse,$(DEB_BUILD_OPTIONS)))
+    PMAKEFLAGS += V=1
+endif
+
 package = xfsprogs
 develop = xfslibs-dev
 bootpkg = xfsprogs-udeb
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] debian: Increase build verbosity, add terse support
  2024-02-12 23:07 ` [PATCH] debian: Increase build verbosity, add terse support Bastian Germann
@ 2024-02-12 23:29   ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2024-02-12 23:29 UTC (permalink / raw)
  To: Bastian Germann; +Cc: linux-xfs, Emanuele Rocca

On Tue, Feb 13, 2024 at 12:07:55AM +0100, Bastian Germann wrote:
> Section 4.9 of the Debian Policy reads:
> 
> "The package build should be as verbose as reasonably possible,
> except where the terse tag is included in DEB_BUILD_OPTIONS".
> 
> Implement such behavior for xfsprogs by passing V=1 to make by default.
> 
> Link: https://www.debian.org/doc/debian-policy/ch-source.html#main-building-script-debian-rules
> Link: https://bugs.debian.org/1063774
> Reported-by: Emanuele Rocca <ema@debian.org>
> Signed-off-by: Bastian Germann <bage@debian.org>

Sounds good to me!
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  debian/rules | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/debian/rules b/debian/rules
> index 57baad62..7e4b83e2 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -7,6 +7,10 @@ ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
>      PMAKEFLAGS += -j$(NUMJOBS)
>  endif
>  
> +ifeq (,$(filter terse,$(DEB_BUILD_OPTIONS)))
> +    PMAKEFLAGS += V=1
> +endif
> +
>  package = xfsprogs
>  develop = xfslibs-dev
>  bootpkg = xfsprogs-udeb
> -- 
> 2.43.0
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-12 23:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Zco4xFPmGJQshw7n@ariel>
2024-02-12 23:07 ` [PATCH] debian: Increase build verbosity, add terse support Bastian Germann
2024-02-12 23:29   ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).