Re: shmem patches headsup: Re: [ANNOUNCE] xfs-linux: for-next updated to 9ee85f235efe

Darrick J. Wong
2024-02-14T17:04:01Z

On Wed, Feb 14, 2024 at 01:51:42PM +0530, Chandan Babu R wrote:
> On Wed, Feb 14, 2024 at 09:03:05 AM +0100, Christoph Hellwig wrote:
> > On Wed, Feb 14, 2024 at 12:18:41PM +0530, Chandan Babu R wrote:
> >> The for-next branch of the xfs-linux repository at:
> >>
> >> https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> >>
> >> has just been updated.
> >
> > <snip>
> >
> >> Christoph Hellwig (17):
> >> [f23e079e024c] mm: move mapping_set_update out of <linux/swap.h>
> >> [604ee858a8c8] shmem: move shmem_mapping out of line
> >> [8481cd645af6] shmem: set a_ops earlier in shmem_symlink
> >> [9b4ec2cf0154] shmem: move the shmem_mapping assert into shmem_get_folio_gfp
> >> [36e3263c623a] shmem: export shmem_get_folio
> >> [74f6fd19195a] shmem: export shmem_kernel_file_setup
> >> [eb84b86441e3] shmem: document how to "persist" data when using shmem_*file_setup
> >
> > I would have prefer an ACK or even a shared branch in the MM tree
> > for these. But as it's been impossible to get any feedback from
> > the shmem and mm maintainer maybe this is the right thing to do.
> >
>
> I am sorry. I completely forgot about the requirement for an ack from the MM
> maintainers. Thanks for bringing it to notice.

These seven patches have been out for review for nineteen days.

Patches 4, 5, and 7 have been out for review for FORTY TWO DAYS.

willy reviewed them after I asked him (thank you willy!), but this kind
of lead time for fairly minor patches is unworkable.

If you two are so overworked that you cannot provide feedback in under
six weeks, then I really need you to ask your manager for more help
hiring staff so that you can delegate tasks and unburden yourselves.
Stalling everyone else is a shitty thing to do. Long feedback cycles
are destructive to developing things together -- look at what XFS has
become.

Or just let the patches go in and hch and I will deal with the
regression reports. Maybe we'll even learn a few things in the process.
Spreading knowledge around the community and decentralizing to reduce
bus factor are two key points of free software, right?

In the meantime, this is blocking me from preparing online repair pull
requests for XFS for 6.9 because those patches need the stuff at the end
of the diet-v3 series.

--D

> --
> Chandan
>