public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: use kvfree() in xfs_ioc_attr_list()
@ 2024-02-20  0:09 Dave Chinner
  2024-02-20  5:04 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Chinner @ 2024-02-20  0:09 UTC (permalink / raw)
  To: linux-xfs; +Cc: chandan.babu

From: Dave Chinner <dchinner@redhat.com>

Wrongly converted from kmem_free() to kfree().

Reported-by: Matthew Wilcox <willy@infradead.org>
Fixes: 49292576136f ("xfs: convert kmem_free() for kvmalloc users to kvfree()")
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 fs/xfs/xfs_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 7eeebcb6b925..02605474dc19 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -435,7 +435,7 @@ xfs_ioc_attr_list(
 	    copy_to_user(ucursor, &context.cursor, sizeof(context.cursor)))
 		error = -EFAULT;
 out_free:
-	kfree(buffer);
+	kvfree(buffer);
 	return error;
 }
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs: use kvfree() in xfs_ioc_attr_list()
  2024-02-20  0:09 [PATCH] xfs: use kvfree() in xfs_ioc_attr_list() Dave Chinner
@ 2024-02-20  5:04 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2024-02-20  5:04 UTC (permalink / raw)
  To: Dave Chinner; +Cc: linux-xfs, chandan.babu

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-20  5:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20  0:09 [PATCH] xfs: use kvfree() in xfs_ioc_attr_list() Dave Chinner
2024-02-20  5:04 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox