From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/9] xfs: move RT inode locking out of __xfs_bunmapi
Date: Tue, 20 Feb 2024 06:10:04 +0100 [thread overview]
Message-ID: <20240220051004.GA5988@lst.de> (raw)
In-Reply-To: <ZdPqj0gJhBekH+Kg@dread.disaster.area>
On Tue, Feb 20, 2024 at 10:55:59AM +1100, Dave Chinner wrote:
> I'd also like to see the rest of the rt-only code in __xfs_bunmapi()
> lifted out of the function into a helper. It's a big chunk of code
> inside the loop, and the code structure is:
Yes, this code has been bothering me forever, and I've started at least
three attempts at cleaning it up and for now given them up due to the
really compliated exit conditions. I think it really should be done
eventually, but I don't plan to add it to this series. It will probably
end up changing some of the existing loop logic as some of that is
pretty questionable and predates the nice iext iterators.
next prev parent reply other threads:[~2024-02-20 5:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 6:34 bring back RT delalloc support Christoph Hellwig
2024-02-19 6:34 ` [PATCH 1/9] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions Christoph Hellwig
2024-02-19 6:34 ` [PATCH 2/9] xfs: move RT inode locking out of __xfs_bunmapi Christoph Hellwig
2024-02-19 23:55 ` Dave Chinner
2024-02-20 5:10 ` Christoph Hellwig [this message]
2024-02-19 6:34 ` [PATCH 3/9] xfs: split xfs_mod_freecounter Christoph Hellwig
2024-02-19 23:21 ` Dave Chinner
2024-02-20 7:28 ` Christoph Hellwig
2024-02-20 16:08 ` Christoph Hellwig
2024-02-21 0:00 ` Dave Chinner
2024-02-19 6:34 ` [PATCH 4/9] xfs: reinstate RT support in xfs_bmapi_reserve_delalloc Christoph Hellwig
2024-02-19 6:34 ` [PATCH 5/9] xfs: cleanup fdblock/frextent accounting in xfs_bmap_del_extent_delay Christoph Hellwig
2024-02-19 6:34 ` [PATCH 6/9] xfs: support RT inodes in xfs_mod_delalloc Christoph Hellwig
2024-02-19 23:30 ` Dave Chinner
2024-02-20 5:14 ` Christoph Hellwig
2024-02-19 6:34 ` [PATCH 7/9] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations Christoph Hellwig
2024-02-19 6:34 ` [PATCH 8/9] xfs: stop the steal (of data blocks for RT indirect blocks) Christoph Hellwig
2024-02-19 23:47 ` Dave Chinner
2024-02-20 5:13 ` Christoph Hellwig
2024-02-19 6:34 ` [PATCH 9/9] xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220051004.GA5988@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox