[PATCH v2] xfs: fix log recovery erroring out on refcount recovery failure

Darrick J. Wong
2024-02-23T05:48:17Z

From: Darrick J. Wong <djwong@kernel.org>

Per the comment in the error case of xfs_reflink_recover_cow, zero out
any error (after shutting down the log) so that we actually kill any new
intent items that might have gotten logged by later recovery steps.
Discovered by xfs/434, which few people actually seem to run.

Fixes: 2c1e31ed5c88 ("xfs: place intent recovery under NOFS allocation context")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
v2: actually send it to the list this time
---
fs/xfs/xfs_log_recover.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index cd134830a695..13f1d2e91540 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -3532,6 +3532,7 @@ xlog_recover_finish(
* and AIL.
*/
xlog_force_shutdown(log, SHUTDOWN_LOG_IO_ERROR);
+ error = 0;
goto out_error;
}