Re: [PATCH 01/10] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions

Darrick J. Wong
2024-02-23T16:29:21Z

On Fri, Feb 23, 2024 at 08:14:57AM +0100, Christoph Hellwig wrote:
> Commit bb7b1c9c5dd3 ("xfs: tag transactions that contain intent done
> items") switched the XFS_TRANS_ definitions to be bit based, and using
> comments above the definitions. As XFS_TRANS_LOWMODE was last and has
> a big fat comment it was missed. Switch it to the same style.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> fs/xfs/libxfs/xfs_shared.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
> index 4220d3584c1b0b..6f1cedb850eb39 100644
> --- a/fs/xfs/libxfs/xfs_shared.h
> +++ b/fs/xfs/libxfs/xfs_shared.h
> @@ -70,7 +70,6 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp,
> #define XFS_TRANS_RES_FDBLKS (1u << 6)
> /* Transaction contains an intent done log item */
> #define XFS_TRANS_HAS_INTENT_DONE (1u << 7)
> -
> /*
> * LOWMODE is used by the allocator to activate the lowspace algorithm - when
> * free space is running low the extent allocator may choose to allocate an
> @@ -82,7 +81,7 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp,
> * for free space from AG 0. If the correct transaction reservations have been
> * made then this algorithm will eventually find all the space it needs.
> */
> -#define XFS_TRANS_LOWMODE 0x100 /* allocate in low space mode */
> +#define XFS_TRANS_LOWMODE (1u << 8)
>
> /*
> * Field values for xfs_trans_mod_sb.
> --
> 2.39.2
>
>