Re: [PRBOMB] xfs: online repair patches for 6.9

Dave Chinner
2024-02-26T12:53:51Z

On Mon, Feb 26, 2024 at 02:26:46AM -0800, Christoph Hellwig wrote:
> On Fri, Feb 23, 2024 at 05:02:20PM -0800, Darrick J. Wong wrote:
> > pc : kfree+0x54/0x2d8
> > lr : xlog_cil_committed+0x11c/0x1d8 [xfs]
>
> This looks a lot like the bug I found in getbmap. Maybe try changing
> that kfree to a kvfree?

yup, I think it is - it's the freeing of the logvec chain that does
it, I think. That memory comes from xlog_kvmalloc().

I have no idea how I haven't tripped over that in my testing as I've
done plenty of 64kB directory block size testing in the past few
weeks...

I'll get a patch out for it and the other kfree issue that was
reported late last week tomorrow...

-Dave.
--
Dave Chinner
david@fromorbit.com