Re: [PRBOMB] xfs: online repair patches for 6.9

Chandan Babu R
2024-02-26T13:07:08Z

On Mon, Feb 26, 2024 at 06:29:43 PM +0530, Chandan Babu R wrote:
> On Mon, Feb 26, 2024 at 02:26:46 AM -0800, Christoph Hellwig wrote:
>> On Fri, Feb 23, 2024 at 05:02:20PM -0800, Darrick J. Wong wrote:
>>> pc : kfree+0x54/0x2d8
>>> lr : xlog_cil_committed+0x11c/0x1d8 [xfs]
>>
>> This looks a lot like the bug I found in getbmap. Maybe try changing
>> that kfree to a kvfree?
>
> CIL context structures are allocated using kzalloc() (i.e. kmalloc() with
> __GFP_ZERO flag appended to flags argument). So kfree() should work right?
>

Sorry, I read Dave's email now. I had mistakenly thought that the call to
kfree() is the one which frees CIL context structure.

--
Chandan