Re: [PATCH 1/2] xfs: xfs_btree_bload_prep_block() should use __GFP_NOFAIL

Darrick J. Wong
2024-02-27T00:47:08Z

On Tue, Feb 27, 2024 at 11:05:31AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> This was missed in the conversion from KM* flags.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Fixes: 10634530f7ba ("xfs: convert kmem_zalloc() to kzalloc()")
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks correct to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> fs/xfs/libxfs/xfs_btree_staging.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_btree_staging.c b/fs/xfs/libxfs/xfs_btree_staging.c
> index f0c69f9bb169..e6ec01f25d90 100644
> --- a/fs/xfs/libxfs/xfs_btree_staging.c
> +++ b/fs/xfs/libxfs/xfs_btree_staging.c
> @@ -406,7 +406,7 @@ xfs_btree_bload_prep_block(
>
> /* Allocate a new incore btree root block. */
> new_size = bbl->iroot_size(cur, level, nr_this_block, priv);
> - ifp->if_broot = kzalloc(new_size, GFP_KERNEL);
> + ifp->if_broot = kzalloc(new_size, GFP_KERNEL | __GFP_NOFAIL);
> ifp->if_broot_bytes = (int)new_size;
>
> /* Initialize it and send it out. */
> --
> 2.43.0
>
>