From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Cc: chandanbabu@kernel.org
Subject: [PATCH 1/2] xfs: xfs_btree_bload_prep_block() should use __GFP_NOFAIL
Date: Tue, 27 Feb 2024 11:05:31 +1100 [thread overview]
Message-ID: <20240227001135.718165-2-david@fromorbit.com> (raw)
In-Reply-To: <20240227001135.718165-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
This was missed in the conversion from KM* flags.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 10634530f7ba ("xfs: convert kmem_zalloc() to kzalloc()")
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/libxfs/xfs_btree_staging.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_btree_staging.c b/fs/xfs/libxfs/xfs_btree_staging.c
index f0c69f9bb169..e6ec01f25d90 100644
--- a/fs/xfs/libxfs/xfs_btree_staging.c
+++ b/fs/xfs/libxfs/xfs_btree_staging.c
@@ -406,7 +406,7 @@ xfs_btree_bload_prep_block(
/* Allocate a new incore btree root block. */
new_size = bbl->iroot_size(cur, level, nr_this_block, priv);
- ifp->if_broot = kzalloc(new_size, GFP_KERNEL);
+ ifp->if_broot = kzalloc(new_size, GFP_KERNEL | __GFP_NOFAIL);
ifp->if_broot_bytes = (int)new_size;
/* Initialize it and send it out. */
--
2.43.0
next prev parent reply other threads:[~2024-02-27 0:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 0:05 [PATCH 0/2] xfs: kmalloc/kfree conversion fixes Dave Chinner
2024-02-27 0:05 ` Dave Chinner [this message]
2024-02-27 0:47 ` [PATCH 1/2] xfs: xfs_btree_bload_prep_block() should use __GFP_NOFAIL Darrick J. Wong
2024-02-27 14:48 ` Christoph Hellwig
2024-02-27 0:05 ` [PATCH 2/2] xfs: use kvfree() in xlog_cil_free_logvec() Dave Chinner
2024-02-27 0:46 ` Darrick J. Wong
2024-02-27 2:37 ` Dave Chinner
2024-02-27 3:01 ` [PATCH v2 " Dave Chinner
2024-02-27 4:25 ` Darrick J. Wong
2024-02-28 2:31 ` Darrick J. Wong
2024-02-27 8:45 ` Chandan Babu R
2024-02-27 14:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227001135.718165-2-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=chandanbabu@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox