From: "Darrick J. Wong" <djwong@kernel.org>
To: zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, guan@eryu.me, fstests@vger.kernel.org
Subject: [PATCH v1.1 2/8] xfs/155: fail the test if xfs_repair hangs for too long
Date: Mon, 26 Feb 2024 20:41:00 -0800 [thread overview]
Message-ID: <20240227044100.GU616564@frogsfrogsfrogs> (raw)
In-Reply-To: <170899915247.896550.12193016117687961302.stgit@frogsfrogsfrogs>
There are a few hard to reproduce bugs in xfs_repair where it can
deadlock trying to lock a buffer that it already owns. These stalls
cause fstests never to finish, which is annoying! To fix this, set up
the xfs_repair run to abort after 10 minutes, which will affect the
golden output and capture a core file.
This doesn't fix xfs_repair, obviously.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
v1.1: require timeout command
---
tests/xfs/155 | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/xfs/155 b/tests/xfs/155
index 302607b510..3181bfaf6f 100755
--- a/tests/xfs/155
+++ b/tests/xfs/155
@@ -26,6 +26,11 @@ _require_scratch_nocheck
_require_scratch_xfs_crc # needsrepair only exists for v5
_require_populate_commands
_require_libxfs_debug_flag LIBXFS_DEBUG_WRITE_CRASH
+_require_command "$TIMEOUT_PROG" timeout
+
+# Inject a 10 minute abortive timeout on the repair program so that deadlocks
+# in the program do not cause fstests to hang indefinitely.
+XFS_REPAIR_PROG="timeout -s ABRT 10m $XFS_REPAIR_PROG"
# Populate the filesystem
_scratch_populate_cached nofill >> $seqres.full 2>&1
next prev parent reply other threads:[~2024-02-27 4:41 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:00 [PATCHSET] fstests: random fixes for v2024.02.09 Darrick J. Wong
2024-02-27 2:00 ` [PATCH 1/8] generic/604: try to make race occur reliably Darrick J. Wong
2024-02-27 4:04 ` Zorro Lang
2024-02-27 4:27 ` Darrick J. Wong
2024-02-27 4:40 ` [PATCH v1.1 " Darrick J. Wong
2024-02-27 5:15 ` Zorro Lang
2024-02-27 14:52 ` Christoph Hellwig
2024-03-02 11:44 ` Zorro Lang
2024-02-27 2:01 ` [PATCH 2/8] xfs/155: fail the test if xfs_repair hangs for too long Darrick J. Wong
2024-02-27 4:16 ` Zorro Lang
2024-02-27 4:41 ` Darrick J. Wong [this message]
2024-02-27 5:14 ` [PATCH v1.1 " Zorro Lang
2024-02-27 14:52 ` Christoph Hellwig
2024-02-27 2:01 ` [PATCH 3/8] generic/192: fix spurious timeout Darrick J. Wong
2024-02-27 4:23 ` Zorro Lang
2024-02-27 4:29 ` Darrick J. Wong
2024-02-27 14:53 ` Christoph Hellwig
2024-02-27 2:01 ` [PATCH 4/8] generic/491: increase test timeout Darrick J. Wong
2024-02-27 4:28 ` Zorro Lang
2024-02-27 14:53 ` Christoph Hellwig
2024-02-27 2:01 ` [PATCH 5/8] xfs/599: reduce the amount of attrs created here Darrick J. Wong
2024-02-27 4:33 ` Zorro Lang
2024-02-27 2:02 ` [PATCH 6/8] xfs/122: update test to pick up rtword/suminfo ondisk unions Darrick J. Wong
2024-02-27 5:10 ` Zorro Lang
2024-02-27 14:54 ` Christoph Hellwig
2024-02-28 1:27 ` Darrick J. Wong
2024-02-28 15:39 ` Christoph Hellwig
2024-02-29 17:48 ` Darrick J. Wong
2024-02-29 19:42 ` Christoph Hellwig
2024-03-01 13:18 ` Zorro Lang
2024-03-01 17:50 ` Darrick J. Wong
2024-03-02 4:55 ` Zorro Lang
2024-03-07 23:24 ` Darrick J. Wong
2024-02-27 2:02 ` [PATCH 7/8] xfs/43[4-6]: make module reloading optional Darrick J. Wong
2024-02-27 5:31 ` Zorro Lang
2024-02-28 1:28 ` Darrick J. Wong
2024-03-01 17:51 ` [PATCH v1.1 " Darrick J. Wong
2024-03-02 12:04 ` Zorro Lang
2024-02-27 2:02 ` [PATCH 8/8] xfs: test for premature ENOSPC with large cow delalloc extents Darrick J. Wong
2024-02-27 6:00 ` Zorro Lang
2024-02-28 1:36 ` Darrick J. Wong
2024-03-01 17:52 ` [PATCH v1.1 " Darrick J. Wong
2024-03-02 20:50 ` Zorro Lang
2024-03-07 23:17 ` Darrick J. Wong
2024-03-07 23:22 ` [PATCH v1.2 " Darrick J. Wong
2024-03-10 9:17 ` Zorro Lang
2024-03-10 16:26 ` Darrick J. Wong
2024-03-11 13:40 ` Zorro Lang
2024-03-11 15:04 ` Darrick J. Wong
2024-03-03 13:34 ` [PATCHSET] fstests: random fixes for v2024.02.09 Zorro Lang
2024-03-07 23:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227044100.GU616564@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox