From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/2] xfs: only add log incompat features with explicit permission
Date: Tue, 27 Feb 2024 10:19:10 -0800 [thread overview]
Message-ID: <20240227181910.GY616564@frogsfrogsfrogs> (raw)
In-Reply-To: <Zd4lUAcj2zSX74R7@infradead.org>
On Tue, Feb 27, 2024 at 10:09:20AM -0800, Christoph Hellwig wrote:
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> (although the CAP_SYS_ADMIN override is a bit odd if we explicitly
> asked to not do automagic feature upgrades)
Wellll... it's 'add_log_feat' (allow adding log features) or
"noadd_log_feat" (stop allowing adding log features). There's no
setting for "don't allow, even for sysadmins".
I could turn it into a stringly typed option "log_feat={allow,forbid}"
but yuck. ;)
--D
next prev parent reply other threads:[~2024-02-27 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:17 [PATCHSET v29.4 01/13] xfs: improve log incompat feature handling Darrick J. Wong
2024-02-27 2:19 ` [PATCH 1/2] xfs: only clear log incompat flags at clean unmount Darrick J. Wong
2024-02-27 18:08 ` Christoph Hellwig
2024-02-27 2:19 ` [PATCH 2/2] xfs: only add log incompat features with explicit permission Darrick J. Wong
2024-02-27 18:09 ` Christoph Hellwig
2024-02-27 18:19 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-27 1:46 [PATCHSET v30.1 02/15] xfs: improve log incompat feature handling Darrick J. Wong
2024-03-27 1:51 ` [PATCH 2/2] xfs: only add log incompat features with explicit permission Darrick J. Wong
2024-04-07 23:00 ` Dave Chinner
2024-04-09 22:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227181910.GY616564@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox