public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] xfs: Remove duplicate include
@ 2024-02-28  3:56 Jiapeng Chong
  2024-02-28  3:56 ` [PATCH 2/2] " Jiapeng Chong
  2024-02-28  4:01 ` [PATCH 1/2] " Darrick J. Wong
  0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2024-02-28  3:56 UTC (permalink / raw)
  To: chandan.babu; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot

./fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8386
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/xfs/xfs_qm_bhv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c
index 271c1021c733..a11436579877 100644
--- a/fs/xfs/xfs_qm_bhv.c
+++ b/fs/xfs/xfs_qm_bhv.c
@@ -11,7 +11,6 @@
 #include "xfs_trans_resv.h"
 #include "xfs_mount.h"
 #include "xfs_quota.h"
-#include "xfs_mount.h"
 #include "xfs_inode.h"
 #include "xfs_trans.h"
 #include "xfs_qm.h"
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] xfs: Remove duplicate include
  2024-02-28  3:56 [PATCH 1/2] xfs: Remove duplicate include Jiapeng Chong
@ 2024-02-28  3:56 ` Jiapeng Chong
  2024-02-28  4:02   ` Darrick J. Wong
  2024-02-28  4:01 ` [PATCH 1/2] " Darrick J. Wong
  1 sibling, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2024-02-28  3:56 UTC (permalink / raw)
  To: chandan.babu; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot

./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/xfs/xfs_trace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
index 1a963382e5e9..23e906b60f21 100644
--- a/fs/xfs/xfs_trace.c
+++ b/fs/xfs/xfs_trace.c
@@ -17,7 +17,6 @@
 #include "xfs_btree.h"
 #include "xfs_da_btree.h"
 #include "xfs_alloc.h"
-#include "xfs_bmap.h"
 #include "xfs_attr.h"
 #include "xfs_trans.h"
 #include "xfs_log.h"
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] xfs: Remove duplicate include
  2024-02-28  3:56 [PATCH 1/2] xfs: Remove duplicate include Jiapeng Chong
  2024-02-28  3:56 ` [PATCH 2/2] " Jiapeng Chong
@ 2024-02-28  4:01 ` Darrick J. Wong
  1 sibling, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2024-02-28  4:01 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: chandan.babu, linux-xfs, linux-kernel, Abaci Robot

On Wed, Feb 28, 2024 at 11:56:11AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8386
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_qm_bhv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c
> index 271c1021c733..a11436579877 100644
> --- a/fs/xfs/xfs_qm_bhv.c
> +++ b/fs/xfs/xfs_qm_bhv.c
> @@ -11,7 +11,6 @@
>  #include "xfs_trans_resv.h"
>  #include "xfs_mount.h"
>  #include "xfs_quota.h"
> -#include "xfs_mount.h"
>  #include "xfs_inode.h"
>  #include "xfs_trans.h"
>  #include "xfs_qm.h"
> -- 
> 2.20.1.7.g153144c
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] xfs: Remove duplicate include
  2024-02-28  3:56 ` [PATCH 2/2] " Jiapeng Chong
@ 2024-02-28  4:02   ` Darrick J. Wong
  0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2024-02-28  4:02 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: chandan.babu, linux-xfs, linux-kernel, Abaci Robot

On Wed, Feb 28, 2024 at 11:56:12AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/xfs/xfs_trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 1a963382e5e9..23e906b60f21 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -17,7 +17,6 @@
>  #include "xfs_btree.h"
>  #include "xfs_da_btree.h"
>  #include "xfs_alloc.h"
> -#include "xfs_bmap.h"

Shouldn't this remove the second #include?

--D

>  #include "xfs_attr.h"
>  #include "xfs_trans.h"
>  #include "xfs_log.h"
> -- 
> 2.20.1.7.g153144c
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-28  4:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-28  3:56 [PATCH 1/2] xfs: Remove duplicate include Jiapeng Chong
2024-02-28  3:56 ` [PATCH 2/2] " Jiapeng Chong
2024-02-28  4:02   ` Darrick J. Wong
2024-02-28  4:01 ` [PATCH 1/2] " Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox