From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] shared/298: run xfs_db against the loop device instead of the image file
Date: Sat, 2 Mar 2024 11:51:50 -0800 [thread overview]
Message-ID: <20240302195150.GV6226@frogsfrogsfrogs> (raw)
In-Reply-To: <20240302140141.GA1170@lst.de>
On Sat, Mar 02, 2024 at 03:01:41PM +0100, Christoph Hellwig wrote:
> On Fri, Mar 01, 2024 at 09:47:56AM -0800, Darrick J. Wong wrote:
> > Might want to leave a comment here about why xfs uses $loop_dev unlike
> > the other clauses that use $img_file
>
> Well, as I tried to explain in my commit message running it against
> the file always seemed weird. The loop device is the canonical place
> to run fs tools against. I can throw in a cleanup patch to also do
> this for the other file systems.
That would also work.
--D
next prev parent reply other threads:[~2024-03-02 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:28 [PATCH] shared/298: run xfs_db against the loop device instead of the image file Christoph Hellwig
2024-03-01 17:47 ` Darrick J. Wong
2024-03-02 14:01 ` Christoph Hellwig
2024-03-02 19:51 ` Darrick J. Wong [this message]
2024-03-03 13:10 ` Zorro Lang
2024-03-03 14:15 ` Christoph Hellwig
2024-03-03 14:41 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302195150.GV6226@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox