Re: [PATCH 7/8] xfs_repair: don't create block maps for data files

Christoph Hellwig
2024-03-17T21:11:11Z

On Thu, Mar 14, 2024 at 05:02:56PM -0700, Darrick J. Wong wrote:
> > Maybe throw a comment in here? Or even add a little helper with the
> > comment?
>
> /*
> * Repair doesn't care about the block maps for regular file data
> * because it never tries to read data blocks. Only spend time on
> * constructing a block map for directories, quota files, symlinks,
> * and realtime space metadata.
> */
> if (dino->di_format != XFS_DINODE_FMT_LOCAL &&
> (type != XR_INO_RTDATA && type != XR_INO_DATA))
> *dblkmap = blkmap_alloc(*nextents, XFS_DATA_FORK);
>
> I'll change the commit message too.

With that:

Reviewed-by: Christoph Hellwig <hch@lst.de>