Re: [PATCH 02/13] mkfs: fix log sunit rounding when external logs are in use

Darrick J. Wong
2024-03-14T23:43:41Z

On Wed, Mar 13, 2024 at 02:59:39PM -0700, Christoph Hellwig wrote:
> On Tue, Mar 12, 2024 at 06:50:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Due to my heinous nature, I set up an external log device with 4k LBAs
> > using this command:
> >
> > # losetup -b 4096 -o 4096 --sizelimit $(( (128 * 1048576) - 4096 )) -f /dev/sdb
> > # blockdev --getsize64 /dev/loop0
> > 134213632
> >
> > This creates a log device that is slightly smaller than 128MB in size.
> > Next I ran generic/054, which sets the log sunit to 256k and fails:
>
> Can we wire this exact mkfs command line up as an xfstests instead of
> requiring a very unused setup to trigger it with the existing test?

I'll have a look at creating an fstests for this sort of thing, unless
the LBS folks already have one handy?

--D

> The xfstests patch itself looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>