Re: [PATCH 7/8] xfs_repair: don't create block maps for data files

Christoph Hellwig
2024-03-14T02:05:27Z

On Tue, Mar 12, 2024 at 07:16:29PM -0700, Darrick J. Wong wrote:
> -
> - if (dino->di_format != XFS_DINODE_FMT_LOCAL && type != XR_INO_RTDATA)
> + if (dino->di_format != XFS_DINODE_FMT_LOCAL &&
> + (type != XR_INO_RTDATA && type != XR_INO_DATA))

Maybe throw a comment in here? Or even add a little helper with the
comment?

The logic change itself looks fine.