Re: [PATCH 3/5] xfs_repair: compute refcount data from in-memory rmap btrees

Darrick J. Wong
2024-03-26T17:22:09Z

On Mon, Mar 25, 2024 at 10:55:14PM -0700, Christoph Hellwig wrote:
> > +#define RMAP_NEXT(r) ((r)->rm_startblock + (r)->rm_blockcount)
>
> Maybe kill this just like we did in the kernel?

It goes away in patch 3 of the next patchset.

> Otherwise this looks fine. Note that it looks very similar but not the
> same as the kernel code. I guess sharing more code was considered but
> didn't work out for some reason? Mabye document that in the commit
> log?

Ok. The rcbag btree in xfs_repair has a different record format than
the one in the kernel because we store owner numbers so that xfs_repair
can compute the bitmap of files that need to have the reflink iflag set.

I'll make a note of that in "xfs_repair: define an in-memory btree for
storing refcount bag info".

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D