Re: [PATCH 1/5] xfs_repair: convert regular rmap repair to use in-memory btrees

Christoph Hellwig
2024-03-26T05:49:13Z

On Mon, Mar 25, 2024 at 09:00:31PM -0700, Darrick J. Wong wrote:
> +char *kvasprintf(const char *fmt, va_list ap)

> +char *kasprintf(const char *fmt, ...)

Any reason these implementations don't simply use vasprinf/asprintf?
The calling conventions are a little differet, but the wrappers are
pretty trivial, e.g.:

http://git.infradead.org/?p=users/hch/xfsprogs.git;a=commitdiff;h=1f66530b2104b2f5e47aef76fce62df436a8f004

for asprintf.

Also in general іt's nice to split such infrastruture additions into
separate commits.

The rest looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>