Re: [PATCH 2/5] xfs_db: fix alignment checks in getbitval

Darrick J. Wong
2024-03-26T17:31:08Z

On Tue, Mar 26, 2024 at 09:36:04AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 26, 2024 at 09:28:21AM -0700, Darrick J. Wong wrote:
> > Well we could still use the regular ones for aligned access, e.g.
>
> We could, but is it worth the effort? The few xfs_db command that
> do this bit en/decoding are ery much the definition of a slow path.

Seeing as it's the debugger I don't really care about maximal
performance anyway. :)

You might have noticed that the rtgroups patchset formally defines the
rtbitmap words to have le32 ordering (instead of host ordering like we
do now), at which point getbitval will need to be extended to handle
little endian conversions. This is also useful for decoding fsverity
descriptors.

So I'll go with the less clutter approach.

--D