Re: [PATCH 1/1] mkfs: use libxfs to create symlinks

Darrick J. Wong
2024-03-26T17:08:17Z

On Mon, Mar 25, 2024 at 10:56:45PM -0700, Christoph Hellwig wrote:
> On Mon, Mar 25, 2024 at 09:02:53PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Now that we've grabbed the kernel-side symlink writing function, use it
> > to create symbolic links from protofiles.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > libxfs/libxfs_api_defs.h | 1 +
> > mkfs/proto.c | 72 ++++++++++++++++++++++++----------------------
> > 2 files changed, 39 insertions(+), 34 deletions(-)
>
> Not really a huge saving :( But the changes looks good:

Yeah, it's sad that using common code *increases* LOC...

> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks for reviewing!

--D