Re: [PATCH 14/15] xfs: introduce new file range commit ioctls

Darrick J. Wong
2024-03-29T19:45:17Z

On Wed, Mar 27, 2024 at 04:06:48AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 26, 2024 at 06:56:29PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > This patch introduces two more new ioctls to manage atomic updates to
> > file contents -- XFS_IOC_START_COMMIT and XFS_IOC_COMMIT_RANGE. The
> > commit mechanism here is exactly the same as what XFS_IOC_EXCHANGE_RANGE
> > does, but with the additional requirement that file2 cannot have changed
> > since some sampling point. The start-commit ioctl performs the sampling
> > of file attributes.
>
> Unless we actually have a good use case for this right now I'd still
> prefer to skip it.

<nod> I'll leave this in djwong-wtf for review, but eventually I'll turn
it into a separate branch that can be picked up or not.

--D