Re: [PATCH 06/13] xfs: split xfs_mod_freecounter

Dave Chinner
2024-03-28T04:18:45Z

On Wed, Mar 27, 2024 at 12:03:11PM +0100, Christoph Hellwig wrote:
> xfs_mod_freecounter has two entirely separate code paths for adding or
> subtracting from the free counters. Only the subtract case looks at the
> rsvd flag and can return an error.
>
> Split xfs_mod_freecounter into separate helpers for subtracting or
> adding the freecounter, and remove all the impossible to reach error
> handling for the addition case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

A nice improvement.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com