Re: [PATCH 10/13] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations

Christoph Hellwig
2024-03-28T04:34:45Z

On Thu, Mar 28, 2024 at 03:32:50PM +1100, Dave Chinner wrote:
> It took me extra brain cells to realise that this had nested
> function calls because of the way the long line is split. Can we
> change it to look like this:
>
> freesp = xfs_rtx_to_rtb(mp,
> xfs_iomap_freesp(&mp->m_frextents,
> mp->m_low_rtexts, &shift));
>
> Just to make it a little easier to spot the nested function and
> which parameters belong to which function?

Sure. Or maybe even add a local variable.