Re: [PATCH] xfs: don't run tests that require v4 file systems when not supported

Darrick J. Wong
2024-03-28T15:05:43Z

On Thu, Mar 28, 2024 at 03:56:41PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 28, 2024 at 09:59:05PM +0800, Zorro Lang wrote:
> > On Thu, Mar 28, 2024 at 01:17:49PM +0100, Christoph Hellwig wrote:
> > > Add a _require_xfs_nocrc helper that checks that we can mkfs and mount
> > > a crc=0 file systems before running tests that rely on it to avoid failures
> > > on kernels with CONFIG_XFS_SUPPORT_V4 disabled.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> >
> > This change makes sense to me, thanks for this update.
> > By searching "crc=0" in tests/xfs, I got x/096, x/078 and x/300 which
> > are not in this patch. Is there any reason about why they don't need it?
>
> xfs/078 only forces crc=0 for block size <= 1024 bytes. Would be
> kinds sad to disable it just to work around this case.

The crc=0 forcing case seems only to activate if
XFS_MKFS_HAS_NO_META_SUPPORT is non-empty, which happens only if
mkfs.xfs does /not/ support V5 filesystems. Maybe we can drop that
case?

> xfs/096 requires an obsolete mkfs without input validation, but
> I guess adding the doesn't hurt

Why do we even keep this test then? Do we care about xfsprogs 4.5?
4.19^H4 is the oldest LTS kernel...

--D

> xfs/300 needs the check, it doesn't run on my test setup because it
> requires selinux.
>
>