Re: [PATCH] xfs: don't run tests that require v4 file systems when not supported

Christoph Hellwig
2024-03-28T14:56:44Z

On Thu, Mar 28, 2024 at 09:59:05PM +0800, Zorro Lang wrote:
> On Thu, Mar 28, 2024 at 01:17:49PM +0100, Christoph Hellwig wrote:
> > Add a _require_xfs_nocrc helper that checks that we can mkfs and mount
> > a crc=0 file systems before running tests that rely on it to avoid failures
> > on kernels with CONFIG_XFS_SUPPORT_V4 disabled.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> This change makes sense to me, thanks for this update.
> By searching "crc=0" in tests/xfs, I got x/096, x/078 and x/300 which
> are not in this patch. Is there any reason about why they don't need it?

xfs/078 only forces crc=0 for block size <= 1024 bytes. Would be
kinds sad to disable it just to work around this case.

xfs/096 requires an obsolete mkfs without input validation, but
I guess adding the doesn't hurt

xfs/300 needs the check, it doesn't run on my test setup because it
requires selinux.