From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/5] xfs: sparse warning fixes
Date: Wed, 3 Apr 2024 08:28:27 +1100 [thread overview]
Message-ID: <20240402213541.1199959-1-david@fromorbit.com> (raw)
In chasing down a recent regression, I realised I wasn't running
sparse regularly on my "fs/xfs-only" kernel builds, and so I missed
a warning that would have prevented a bug from slipping through.
I've modified my build scripts to always run sparse when I do these
delta builds as I develop code, and I found a few other warnings
that needed to be addressed. No bugs were uncovered - they are
simply modifications and/or annotations to the code to address the
warnings and make them go away.
There remains a couple of sparse warnings in the transaction
reservation calculations - sparse throws "too many tokens" warnings
from the max(t4, max3(t1, t2, t3)) calculations. These are sparse
code parser issues, not a code problem, so I have ignored them for
now.
next reply other threads:[~2024-04-02 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 21:28 Dave Chinner [this message]
2024-04-02 21:28 ` [PATCH 1/5] xfs: fix CIL sparse lock context warnings Dave Chinner
2024-04-03 3:53 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 2/5] xfs: fix sparse warning in xfs_extent_busy_clear Dave Chinner
2024-04-03 4:04 ` Darrick J. Wong
2024-04-03 4:32 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 3/5] xfs: silence sparse warning when checking version number Dave Chinner
2024-04-03 3:57 ` Darrick J. Wong
2024-04-03 4:35 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 4/5] xfs: remove unused is_rt_data_fork() function Dave Chinner
2024-04-03 3:54 ` Darrick J. Wong
2024-04-03 4:35 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 5/5] xfs: fix sparse warnings about unused interval tree functions Dave Chinner
2024-04-03 3:53 ` Darrick J. Wong
2024-04-03 4:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402213541.1199959-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox