Re: [PATCH 22/29] xfs: advertise fs-verity being available on filesystem

Andrey Albershteyn
2024-04-02T13:44:44Z

On 2024-03-29 17:41:48, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Advertise that this filesystem supports fsverity.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_fs.h | 1 +
> fs/xfs/libxfs/xfs_sb.c | 2 ++
> 2 files changed, 3 insertions(+)
>
>
> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> index 6ede243fbecf7..af45a246eb1c1 100644
> --- a/fs/xfs/libxfs/xfs_fs.h
> +++ b/fs/xfs/libxfs/xfs_fs.h
> @@ -247,6 +247,7 @@ typedef struct xfs_fsop_resblks {
> /* file range exchange available to userspace */
> #define XFS_FSOP_GEOM_FLAGS_EXCHANGE_RANGE (1 << 24)
>
> +#define XFS_FSOP_GEOM_FLAGS_VERITY (1U << 28) /* fs-verity */
> #define XFS_FSOP_GEOM_FLAGS_METADIR (1U << 29) /* metadata directories */
> #define XFS_FSOP_GEOM_FLAGS_PARENT (1U << 30) /* parent pointers */
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index 39b5083745d0e..24e22a2dea51c 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -1427,6 +1427,8 @@ xfs_fs_geometry(
> geo->flags |= XFS_FSOP_GEOM_FLAGS_EXCHANGE_RANGE;
> if (xfs_has_metadir(mp))
> geo->flags |= XFS_FSOP_GEOM_FLAGS_METADIR;
> + if (xfs_has_verity(mp))
> + geo->flags |= XFS_FSOP_GEOM_FLAGS_VERITY;
> geo->rtsectsize = sbp->sb_blocksize;
> geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp);
>
>

Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>

--
- Andrey