Re: [PATCH 2/3] xfs: fix an AGI lock acquisition ordering problem in xrep_dinode_findmode

Christoph Hellwig
2024-04-05T16:52:28Z

On Fri, Apr 05, 2024 at 07:54:26AM -0700, Christoph Hellwig wrote:
> >
> > To address this, modify the iscan to allow trylock of the AGI buffer
> > using the flags argument to xfs_ialloc_read_agi that the previous patch
> > added.
>
> Well, I guess we need this as a quick fix, but any scheme based on
> trylock and return is just fundamentally broken.
>
> Same for the next one.

And if this just sounded a little frustrated it with, but it should be
counted as a grudging:

Reviewed-by: Christoph Hellwig <hch@lst.de>

for this and the next patch.