Re: [PATCH 29/32] xfs: Add the parent pointer support to the superblock version 5.

Darrick J. Wong
2024-04-10T22:06:50Z

On Tue, Apr 09, 2024 at 11:05:12PM -0700, Christoph Hellwig wrote:
> On Tue, Apr 09, 2024 at 06:01:04PM -0700, Darrick J. Wong wrote:
> > From: Allison Henderson <allison.henderson@oracle.com>
> >
> > Add the parent pointer superblock flag so that we can actually mount
> > filesystems with this feature enabled.
>
> The subjcet reads a little weird. What about
>
> "add a incompat feature bit for parent pointers" ?

Changed to:

"xfs: add a incompat feature bit for parent pointers

"Create an incompat feature bit and a fs geometry flag so that we can
enable the feature in the ondisk superblock and advertise its existence
to userspace."

Also I'll change the bit to 1<<25; I was using 1U<<30 to avoid
collisions with the other patchsets.

--D