Re: [PATCH 16/32] xfs: create a hashname function for parent pointers

Christoph Hellwig
2024-04-10T05:33:45Z

> + /*
> + * Use the same dirent name hash as would be used on the directory, but
> + * mix in the parent inode number.
> + */
> + ret = xfs_dir2_hashname(mp, &xname);
> + ret ^= upper_32_bits(parent_ino);
> + ret ^= lower_32_bits(parent_ino);
> + return ret;

Totally superficial nit, but wouldn't this read a little nicer as:

return xfs_dir2_hashname(mp, &xname) ^
lower_32_bits(parent_ino) ^
upper_32_bits(parent_ino);

?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>