Re: [PATCH 1/3] xfs: reduce the rate of cond_resched calls inside scrub

Darrick J. Wong
2024-04-10T22:19:14Z

On Wed, Apr 10, 2024 at 07:55:35AM -0700, Christoph Hellwig wrote:
> On Tue, Apr 09, 2024 at 06:08:38PM -0700, Darrick J. Wong wrote:
> > Surprisingly, this reduces scrub-only fstests runtime by about 2%. I
> > used the bmapinflate xfs_db command to produce a billion-extent file and
> > this stupid gadget reduced the scrub runtime by about 4%.
>
> I wish the scheduler maintainers would just finish sorting out the
> preemption models mess and kill cond_resched() and we wouldn't need this.

Yeah, I heard that might not happen or ... something.

> But until then:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D