From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <christian@brauner.io>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] xfs: don't call xfs_file_open from xfs_dir_open
Date: Tue, 23 Apr 2024 14:46:08 +0200 [thread overview]
Message-ID: <20240423124608.537794-4-hch@lst.de> (raw)
In-Reply-To: <20240423124608.537794-1-hch@lst.de>
Directories do not support direct I/O and thus no non-blocking direct
I/O either. Open code the shutdown check and call to generic_file_open
instead.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_file.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 4415d0f3bbc51b..2ce302b4885f53 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1243,7 +1243,9 @@ xfs_dir_open(
unsigned int mode;
int error;
- error = xfs_file_open(inode, file);
+ if (xfs_is_shutdown(ip->i_mount))
+ return -EIO;
+ error = generic_file_open(inode, file);
if (error)
return error;
--
2.39.2
next prev parent reply other threads:[~2024-04-23 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 12:46 xfs fixups for the fop_flags conversion Christoph Hellwig
2024-04-23 12:46 ` [PATCH 1/3] xfs: fix overly long line in the file_operations Christoph Hellwig
2024-04-23 12:46 ` [PATCH 2/3] xfs: drop fop_flags for directories Christoph Hellwig
2024-04-23 12:46 ` Christoph Hellwig [this message]
2024-04-24 3:33 ` xfs fixups for the fop_flags conversion Darrick J. Wong
2024-04-24 12:49 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423124608.537794-4-hch@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=christian@brauner.io \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox