[ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[Chandan Babu R]

Hi folks,

The for-next branch of the xfs-linux repository at:

	https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git

has just been updated.

Patches often get missed, so please check if your outstanding patches
were in this update. If they have not been in this update, please
resubmit them to linux-xfs@vger.kernel.org so they can be picked up in
the next update.

The new head of the for-next branch is commit:

6a94b1acda7e xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)

17 new commits:

Christoph Hellwig (17):
      [e78a3ce28331] xfs: move more logic into xfs_extent_busy_clear_one
      [c37d6ed87462] xfs: unwind xfs_extent_busy_clear
      [c0ac6cb251bd] xfs: remove the unused xfs_extent_busy_enomem trace event
      [4887e5316382] xfs: compile out v4 support if disabled
      [330c4f94b0d7] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions
      [b7e23c0e2e3b] xfs: refactor realtime inode locking
      [9871d0963751] xfs: free RT extents after updating the bmap btree
      [de37dbd0ccc6] xfs: move RT inode locking out of __xfs_bunmapi
      [5e1e4d4fc79c] xfs: block deltas in xfs_trans_unreserve_and_mod_sb must be positive
      [f30f656e25eb] xfs: split xfs_mod_freecounter
      [dc1b17a25c32] xfs: reinstate RT support in xfs_bmapi_reserve_delalloc
      [7e77d57a1fea] xfs: cleanup fdblock/frextent accounting in xfs_bmap_del_extent_delay
      [7099bd0f243f] xfs: support RT inodes in xfs_mod_delalloc
      [727f8431638f] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations
      [da2b9c3a8d2c] xfs: rework splitting of indirect block reservations
      [bd1753d8c42b] xfs: stop the steal (of data blocks for RT indirect blocks)
      [6a94b1acda7e] xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)

Please note that the patch "xfs: fix sparse warning in xfs_extent_busy_clear"
has been dropped now.

Code Diffstat:

 fs/xfs/libxfs/xfs_ag.c           |   4 +--
 fs/xfs/libxfs/xfs_ag_resv.c      |  24 ++++-----------
 fs/xfs/libxfs/xfs_ag_resv.h      |   2 +-
 fs/xfs/libxfs/xfs_alloc.c        |   4 +--
 fs/xfs/libxfs/xfs_bmap.c         | 152 +++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------
 fs/xfs/libxfs/xfs_rtbitmap.c     |  57 +++++++++++++++++++++++++++++++++++
 fs/xfs/libxfs/xfs_rtbitmap.h     |  17 +++++++++++
 fs/xfs/libxfs/xfs_shared.h       |   6 ++--
 fs/xfs/scrub/common.c            |   1 +
 fs/xfs/scrub/fscounters.c        |  12 +++++---
 fs/xfs/scrub/fscounters.h        |   1 +
 fs/xfs/scrub/fscounters_repair.c |  12 +++++++-
 fs/xfs/scrub/repair.c            |   5 +--
 fs/xfs/xfs_extent_busy.c         |  80 ++++++++++++++++++++++--------------------------
 fs/xfs/xfs_fsmap.c               |   4 +--
 fs/xfs/xfs_fsops.c               |  29 +++++-------------
 fs/xfs/xfs_fsops.h               |   2 +-
 fs/xfs/xfs_inode.c               |   3 +-
 fs/xfs/xfs_iomap.c               |  45 ++++++++++++++++++---------
 fs/xfs/xfs_iops.c                |   2 +-
 fs/xfs/xfs_mount.c               |  87 +++++++++++++++++++++++++++++++----------------------
 fs/xfs/xfs_mount.h               |  76 +++++++++++++++++++++++++++++++++++-----------
 fs/xfs/xfs_rtalloc.c             |  22 +++++---------
 fs/xfs/xfs_super.c               |  39 +++++++++++++++---------
 fs/xfs/xfs_trace.h               |   2 --
 fs/xfs/xfs_trans.c               |  63 ++++++++++++++++++++------------------
 26 files changed, 439 insertions(+), 312 deletions(-)

Re: [ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[Dave Chinner]

On Tue, Apr 23, 2024 at 03:46:24PM +0530, Chandan Babu R wrote:
> Hi folks,
> 
> The for-next branch of the xfs-linux repository at:
> 
> 	https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> 
> has just been updated.
> 
> Patches often get missed, so please check if your outstanding patches
> were in this update. If they have not been in this update, please
> resubmit them to linux-xfs@vger.kernel.org so they can be picked up in
> the next update.
> 
> The new head of the for-next branch is commit:
> 
> 6a94b1acda7e xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)

I've just noticed a regression in for-next - it was there prior to
this update, but I hadn't run a 1kB block size fstests run in a
while so I've only just noticed it. It is 100% reproducable, and may
well be a problem with the partial filter matches in the test rather
than a kernel bug...

SECTION       -- xfs_1k
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test1 6.9.0-rc5-dgc+ #219 SMP PREEMPT_DYNAMIC Wed Apr 24 08:30:50 AEST 2024
MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/vdb
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch

xfs/348 19s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad)
    --- tests/xfs/348.out       2022-12-21 15:53:25.579041081 +1100
    +++ /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad     2024-04-24 08:34:43.718525603 +1000
    @@ -2,7 +2,7 @@
     ===== Find inode by file type:
     dt=1 => FIFO_INO
     dt=2 => CHRDEV_INO
    -dt=4 => DIR_INO
    +dt=4 => PARENT_INO108928
     dt=6 => BLKDEV_INO
     dt=10 => DATA_INO
    ...
    (Run 'diff -u /home/dave/src/xfstests-dev/tests/xfs/348.out /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad'  to see the entire diff)
Failures: xfs/348
Failed 1 of 1 tests

xfsprogs version installed on this test VM is:

$ xfs_repair -V
xfs_repair version 6.4.0
$

-Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: [ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[Darrick J. Wong]

On Wed, Apr 24, 2024 at 08:45:23AM +1000, Dave Chinner wrote:
> On Tue, Apr 23, 2024 at 03:46:24PM +0530, Chandan Babu R wrote:
> > Hi folks,
> > 
> > The for-next branch of the xfs-linux repository at:
> > 
> > 	https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> > 
> > has just been updated.
> > 
> > Patches often get missed, so please check if your outstanding patches
> > were in this update. If they have not been in this update, please
> > resubmit them to linux-xfs@vger.kernel.org so they can be picked up in
> > the next update.
> > 
> > The new head of the for-next branch is commit:
> > 
> > 6a94b1acda7e xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)
> 
> I've just noticed a regression in for-next - it was there prior to
> this update, but I hadn't run a 1kB block size fstests run in a
> while so I've only just noticed it. It is 100% reproducable, and may
> well be a problem with the partial filter matches in the test rather
> than a kernel bug...
> 
> SECTION       -- xfs_1k
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 test1 6.9.0-rc5-dgc+ #219 SMP PREEMPT_DYNAMIC Wed Apr 24 08:30:50 AEST 2024
> MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/vdb
> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch
> 
> xfs/348 19s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad)
>     --- tests/xfs/348.out       2022-12-21 15:53:25.579041081 +1100
>     +++ /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad     2024-04-24 08:34:43.718525603 +1000
>     @@ -2,7 +2,7 @@
>      ===== Find inode by file type:
>      dt=1 => FIFO_INO
>      dt=2 => CHRDEV_INO
>     -dt=4 => DIR_INO
>     +dt=4 => PARENT_INO108928

Given:

pino=$(ls -id $testdir | awk '{print $1}')
echo "s/inode $pino/PARENT_INO/" >> $inode_filter

I'd say that pino=35 would then result in:

s/inode 35/PARENT_INO/

Which will then match and transform:

inode 35108928

into:

PARENT_INO108928

So yeah, I agree that the partial filter matches are a problem.

--D

>      dt=6 => BLKDEV_INO
>      dt=10 => DATA_INO
>     ...
>     (Run 'diff -u /home/dave/src/xfstests-dev/tests/xfs/348.out /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad'  to see the entire diff)
> Failures: xfs/348
> Failed 1 of 1 tests
> 
> xfsprogs version installed on this test VM is:
> 
> $ xfs_repair -V
> xfs_repair version 6.4.0
> $
> 
> -Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> 

Re: [ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[Chandan Babu R]

On Wed, Apr 24, 2024 at 08:45:23 AM +1000, Dave Chinner wrote:
> On Tue, Apr 23, 2024 at 03:46:24PM +0530, Chandan Babu R wrote:
>> Hi folks,
>> 
>> The for-next branch of the xfs-linux repository at:
>> 
>> 	https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
>> 
>> has just been updated.
>> 
>> Patches often get missed, so please check if your outstanding patches
>> were in this update. If they have not been in this update, please
>> resubmit them to linux-xfs@vger.kernel.org so they can be picked up in
>> the next update.
>> 
>> The new head of the for-next branch is commit:
>> 
>> 6a94b1acda7e xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)
>
> I've just noticed a regression in for-next - it was there prior to
> this update, but I hadn't run a 1kB block size fstests run in a
> while so I've only just noticed it. It is 100% reproducable, and may
> well be a problem with the partial filter matches in the test rather
> than a kernel bug...
>
> SECTION       -- xfs_1k
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 test1 6.9.0-rc5-dgc+ #219 SMP PREEMPT_DYNAMIC Wed Apr 24 08:30:50 AEST 2024
> MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/vdb
> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch
>
> xfs/348 19s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad)
>     --- tests/xfs/348.out       2022-12-21 15:53:25.579041081 +1100
>     +++ /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad     2024-04-24 08:34:43.718525603 +1000
>     @@ -2,7 +2,7 @@
>      ===== Find inode by file type:
>      dt=1 => FIFO_INO
>      dt=2 => CHRDEV_INO
>     -dt=4 => DIR_INO
>     +dt=4 => PARENT_INO108928
>      dt=6 => BLKDEV_INO
>      dt=10 => DATA_INO
>     ...
>     (Run 'diff -u /home/dave/src/xfstests-dev/tests/xfs/348.out /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad'  to see the entire diff)
> Failures: xfs/348
> Failed 1 of 1 tests
>
> xfsprogs version installed on this test VM is:
>
> $ xfs_repair -V
> xfs_repair version 6.4.0
> $

That is weird. I am unable to recreate this bug on my cloud instance. I am
using fstests version v2024.04.14 and Xfsprogs version 6.7.0.

# ./check xfs/348
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 fstest 6.9.0-rc4-00122-g6a94b1acda7e #13 SMP PREEMPT_DYNAMIC Wed Apr 24 09:48:36 IST 2024
MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/loop1
MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch

xfs/348 7s ...  8s
Ran: xfs/348
Passed all 1 tests

-- 
Chandan

Re: [ANNOUNCE] xfs-linux: for-next updated to 6a94b1acda7e

[Darrick J. Wong]

On Wed, Apr 24, 2024 at 10:49:29AM +0530, Chandan Babu R wrote:
> On Wed, Apr 24, 2024 at 08:45:23 AM +1000, Dave Chinner wrote:
> > On Tue, Apr 23, 2024 at 03:46:24PM +0530, Chandan Babu R wrote:
> >> Hi folks,
> >> 
> >> The for-next branch of the xfs-linux repository at:
> >> 
> >> 	https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> >> 
> >> has just been updated.
> >> 
> >> Patches often get missed, so please check if your outstanding patches
> >> were in this update. If they have not been in this update, please
> >> resubmit them to linux-xfs@vger.kernel.org so they can be picked up in
> >> the next update.
> >> 
> >> The new head of the for-next branch is commit:
> >> 
> >> 6a94b1acda7e xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1)
> >
> > I've just noticed a regression in for-next - it was there prior to
> > this update, but I hadn't run a 1kB block size fstests run in a
> > while so I've only just noticed it. It is 100% reproducable, and may
> > well be a problem with the partial filter matches in the test rather
> > than a kernel bug...
> >
> > SECTION       -- xfs_1k
> > FSTYP         -- xfs (debug)
> > PLATFORM      -- Linux/x86_64 test1 6.9.0-rc5-dgc+ #219 SMP PREEMPT_DYNAMIC Wed Apr 24 08:30:50 AEST 2024
> > MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/vdb
> > MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch
> >
> > xfs/348 19s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad)
> >     --- tests/xfs/348.out       2022-12-21 15:53:25.579041081 +1100
> >     +++ /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad     2024-04-24 08:34:43.718525603 +1000
> >     @@ -2,7 +2,7 @@
> >      ===== Find inode by file type:
> >      dt=1 => FIFO_INO
> >      dt=2 => CHRDEV_INO
> >     -dt=4 => DIR_INO
> >     +dt=4 => PARENT_INO108928
> >      dt=6 => BLKDEV_INO
> >      dt=10 => DATA_INO
> >     ...
> >     (Run 'diff -u /home/dave/src/xfstests-dev/tests/xfs/348.out /home/dave/src/xfstests-dev/results//xfs_1k/xfs/348.out.bad'  to see the entire diff)
> > Failures: xfs/348
> > Failed 1 of 1 tests
> >
> > xfsprogs version installed on this test VM is:
> >
> > $ xfs_repair -V
> > xfs_repair version 6.4.0
> > $
> 
> That is weird. I am unable to recreate this bug on my cloud instance. I am
> using fstests version v2024.04.14 and Xfsprogs version 6.7.0.
> 
> # ./check xfs/348
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 fstest 6.9.0-rc4-00122-g6a94b1acda7e #13 SMP PREEMPT_DYNAMIC Wed Apr 24 09:48:36 IST 2024
> MKFS_OPTIONS  -- -f -m rmapbt=1 -b size=1k /dev/loop1
> MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch
> 
> xfs/348 7s ...  8s
> Ran: xfs/348
> Passed all 1 tests

Same here -- I checked all of yesterday's runs and none of them tripped
over that.  sed \b perhaps?

--D

> -- 
> Chandan
>