Re: [PATCH 07/13] fsverity: pass the new tree size and block size to ->begin_enable_verity

Eric Biggers
2024-04-05T02:46:12Z

On Fri, Mar 29, 2024 at 05:34:30PM -0700, Darrick J. Wong wrote:
> diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h
> index 52de58d6f021f..030d7094d80fc 100644
> --- a/include/linux/fsverity.h
> +++ b/include/linux/fsverity.h
> @@ -82,6 +82,8 @@ struct fsverity_operations {
> * Begin enabling verity on the given file.
> *
> * @filp: a readonly file descriptor for the file
> + * @merkle_tree_size: total bytes the new Merkle tree will take up
> + * @tree_blocksize: the new Merkle tree block size

"new Merkle tree block size" is confusing because there's no old Merkle tree
block size here. Maybe delete "new" from the above two lines.

- Eric