Re: [PATCH 12/29] xfs: widen flags argument to the xfs_iflags_* helpers

Andrey Albershteyn
2024-04-02T12:37:55Z

On 2024-03-29 17:39:11, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> xfs_inode.i_flags is an unsigned long, so make these helpers take that
> as the flags argument instead of unsigned short. This is needed for the
> next patch.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_inode.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>

Would it also make sense to flip iflags to unsigned long in
xfs_iget_cache_miss()?

Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>

--
- Andrey