Re: [PATCH 06/13] fsverity: send the level of the merkle tree block to ->read_merkle_tree_block

Darrick J. Wong
2024-04-25T00:30:12Z

On Thu, Apr 04, 2024 at 10:42:12PM -0400, Eric Biggers wrote:
> On Fri, Mar 29, 2024 at 05:34:14PM -0700, Darrick J. Wong wrote:
> > +/**
> > + * struct fsverity_readmerkle - Request to read a Merkle Tree block buffer
> > + * @inode: the inode to read
> > + * @level: expected level of the block; level 0 are the leaves, -1 means a
> > + * streaming read
> > + * @num_levels: number of levels in the tree total
> > + * @log_blocksize: log2 of the size of the expected block
> > + * @ra_bytes: The number of bytes that should be prefetched starting at pos
> > + * if the page at @block->offset isn't already cached.
> > + * Implementations may ignore this argument; it's only a
> > + * performance optimization.
> > + */
> > +struct fsverity_readmerkle {
> > + struct inode *inode;
> > + unsigned long ra_bytes;
> > + int level;
> > + int num_levels;
> > + u8 log_blocksize;
> > +};
>
> This struct should be introduced in the patch that adds ->read_merkle_tree_block
> originally.

Done.

--D

> - Eric
>