Re: [PATCH 28/29] xfs: allow verity files to be opened even if the fsverity metadata is damaged

Andrey Albershteyn
2024-04-02T18:05:05Z

On 2024-03-29 17:43:22, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> There are more things that one can do with an open file descriptor on
> XFS -- query extended attributes, scan for metadata damage, repair
> metadata, etc. None of this is possible if the fsverity metadata are
> damaged, because that prevents the file from being opened.
>
> Ignore a selective set of error codes that we know fsverity_file_open to
> return if the verity descriptor is nonsense.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/iomap/buffered-io.c | 8 ++++++++
> fs/xfs/xfs_file.c | 19 ++++++++++++++++++-
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
>

Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>

--
- Andrey