Re: [PATCH 27/29] xfs: make it possible to disable fsverity

Eric Biggers
2024-04-02T23:25:12Z

On Fri, Mar 29, 2024 at 05:43:06PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Create an experimental ioctl so that we can turn off fsverity.

The concept of "experimental ioctls" seems problematic. What if people start
relying on them? Linux tends not to have "experimental" system calls, and
probably for good reason...

Also, what is the use case for this ioctl? Is it necessary to have this when
userspace can already just replace a verity file with a copy that has verity
disabled? That's less efficient, but it does not require any kernel support and
does not require CAP_SYS_ADMIN.

And of course, if do we add this ioctl it shouldn't be XFS-specific.

- Eric