From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>,
Sam Sun <samsun1006219@gmail.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: restrict the h_size fixup in xlog_do_recovery_pass
Date: Mon, 29 Apr 2024 19:15:52 +0200 [thread overview]
Message-ID: <20240429171552.GE31337@lst.de> (raw)
In-Reply-To: <Zi-QJG3tuRptnDVX@bfoster>
On Mon, Apr 29, 2024 at 08:18:44AM -0400, Brian Foster wrote:
> > - if (h_len > h_size && h_len <= log->l_mp->m_logbsize &&
> > + if (!xfs_has_reflink(log->l_mp) && xfs_has_reflink(log->l_mp) &&
> > + h_len > h_size && h_len <= log->l_mp->m_logbsize &&
>
> ... but I'm going to assume this hasn't been tested. ;) Do you mean to
> also check !rmapbt here?
Heh. Well, it has been tested in that we don't do the fixup for the
reproducer fixed by the previous patch and in that xfstests still passes.
I guess nothing in there hits the old mkfs fixup, which isn't surprising.
> Can you please also just double check that we still handle the original
> mkfs problem correctly after these changes? I think that just means mkfs
> from a sufficiently old xfsprogs using a larger log stripe unit, and
> confirm the fs mounts (with a warning).
Yeah. Is there any way to commit a fs image to xfstests so that we
actually regularly test for it?
next prev parent reply other threads:[~2024-04-29 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 7:01 fix h_size validation Christoph Hellwig
2024-04-29 7:01 ` [PATCH 1/3] xfs: fix log recovery buffer allocation for the legacy h_size fixup Christoph Hellwig
2024-04-29 12:18 ` Brian Foster
2024-04-29 17:13 ` Christoph Hellwig
2024-04-29 15:53 ` Darrick J. Wong
2024-04-29 7:01 ` [PATCH 2/3] xfs: restrict the h_size fixup in xlog_do_recovery_pass Christoph Hellwig
2024-04-29 12:18 ` Brian Foster
2024-04-29 17:15 ` Christoph Hellwig [this message]
2024-04-30 10:59 ` Brian Foster
2024-05-10 12:34 ` Brian Foster
2024-04-29 15:55 ` Darrick J. Wong
2024-04-29 7:02 ` [PATCH 3/3] xfs: clean up buffer allocation " Christoph Hellwig
2024-04-29 12:18 ` Brian Foster
2024-04-29 15:56 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429171552.GE31337@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=samsun1006219@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).