From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B6D83A15 for ; Mon, 29 Apr 2024 17:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714411125; cv=none; b=I2ejiDy9LdUJnlbkBIpSX4v2aapfivTr9AoPvFRbqaHYf3u9fzitAC0I8jYAf9pC9Fj/bB1B0wMfo9pSc/P57L8cLgtK3qlxcc8FIj5P1NLYvY9upOJs/DTnyvOevDi9lc1u81TUCa6w7gBSZ99gM9qUUwDD2QEGtMSVcMvLfzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714411125; c=relaxed/simple; bh=2jMDIz7IzHAYsreZ0h0MGoPVodLFnAbBZYd46811a5M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T5LTQ6ZtHVtmzpotwikFu2pDvU9BK7Edtmcwi4QUT6I9hRWiAqge4GTmZfC2t3XCOm0sIbOFgXuG0XEuZmsh6VZ7vZFRApNX6G5wY14Cm9/pcElJ8QfjmzEorwkkhb45hxkswDW1+6YWuIUSC4WTtTCJ0J+PiBlEs/aE0O9T4lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id D5F07227A87; Mon, 29 Apr 2024 19:18:40 +0200 (CEST) Date: Mon, 29 Apr 2024 19:18:40 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Dave Chinner , linux-xfs@vger.kernel.org Subject: Re: [PATCH 5/9] xfs: pass the actual offset and len to allocate to xfs_bmapi_allocate Message-ID: <20240429171840.GI31337@lst.de> References: <20240429061529.1550204-1-hch@lst.de> <20240429061529.1550204-6-hch@lst.de> <20240429154817.GB360919@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429154817.GB360919@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Apr 29, 2024 at 08:48:17AM -0700, Darrick J. Wong wrote: > Referencing > https://lore.kernel.org/linux-xfs/20240410040353.GC1883@lst.de/ > > Did you decide against "[moving] the assignments into the other > branch here to make things more obvious"? Yes. I did the move and then noticed that I'd just have to move it back in the last patch, which feels a bit silly.